Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): add error handling when creating a new network #580

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented Aug 4, 2022

This PR adds proper error handling when creating a new network. It will now display an error toast message with more information as to why the creation failed. This should help diagnose the problem in #569.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #580 (4cfa285) into master (1c649f6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #580   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         3295      3297    +2     
  Branches       570       570           
=========================================
+ Hits          3295      3297    +2     
Impacted Files Coverage Δ
src/components/network/NewNetwork.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jamaljsr jamaljsr merged commit 2a6cd1d into master Aug 4, 2022
@jamaljsr jamaljsr deleted the new-network-errors branch August 4, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants