Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lightningd): add Core Lightning GRPC info to sidebar #560

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

jamaljsr
Copy link
Owner

Follow-up PR to #559

Description

Core Lightning now supports GRPC. This PR updates the UI to display the GRPC port and TLS client certificates in the sidebar Connect tab if the node is running v0.11.1 or greater.

Screenshots

image

Base automatically changed from feat/node-updates-0522 to master May 30, 2022 03:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #560 (ab16e4a) into master (1c649f6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         3295      3317   +22     
  Branches       570       581   +11     
=========================================
+ Hits          3295      3317   +22     
Impacted Files Coverage Δ
src/utils/constants.ts 100.00% <ø> (ø)
src/components/designer/lightning/ConnectTab.tsx 100.00% <100.00%> (ø)
...ents/designer/lightning/connect/EncodedStrings.tsx 100.00% <100.00%> (ø)
...omponents/designer/lightning/connect/FilePaths.tsx 100.00% <100.00%> (ø)
src/lib/docker/composeFile.ts 100.00% <100.00%> (ø)
src/lib/docker/nodeTemplates.ts 100.00% <100.00%> (ø)
src/utils/network.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jamaljsr jamaljsr merged commit 4dfed75 into master Aug 4, 2022
@jamaljsr jamaljsr deleted the feat/cln-grpc branch August 4, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants