Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Eclair nodes #322

Merged
merged 13 commits into from
Mar 17, 2020
Merged

Add support for Eclair nodes #322

merged 13 commits into from
Mar 17, 2020

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented Mar 14, 2020

Description

This PR adds support for Eclair v0.3.3. These nodes have all of the same functionality as LND and c-lightning nodes, to deposit funds, open channels, make payments, etc.

There is only one quirk which changes the previous default behavior for all networks. Eclair will not boot up if it connects to a Bitcoin node with 0 mined blocks. You have to mine at least one block for it to not immediately exit on startup. So Polar will now automatically mine the first block for all networks.

ToDo

  • More unit tests
  • Verify everything works on Windows & Linux

Steps to Test

  1. Create a new Network with an Eclair node
  2. Start the network and confirm the Eclair node starts successfully
  3. Deposit funds
  4. Open a channel with another node
  5. Make a payment to and from this node
  6. add another Eclair node from the sidebar
  7. Open the terminal and execute eclair-cli getinfo commands
  8. View the node logs

Screenshots

image

View more screenshots

image

image

image

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #322 into master will decrease coverage by 3.6%.
The diff coverage is 31.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage     100%   96.39%   -3.61%     
==========================================
  Files         111      114       +3     
  Lines        3033     3192     +159     
  Branches      552      581      +29     
==========================================
+ Hits         3033     3077      +44     
- Misses          0      115     +115
Impacted Files Coverage Δ
src/components/designer/NodeContextMenu.tsx 100% <ø> (ø) ⬆️
src/utils/chart.ts 100% <ø> (ø) ⬆️
src/lib/ipc/ipcService.ts 100% <ø> (ø) ⬆️
src/lib/lightning/lightningFactory.ts 100% <ø> (ø) ⬆️
src/lib/docker/composeFile.ts 79.06% <0%> (-20.94%) ⬇️
src/lib/bitcoin/bitcoindService.ts 96.49% <0%> (-3.51%) ⬇️
src/lib/lightning/eclair/eclairService.ts 10.46% <10.46%> (ø)
src/components/network/NewNetwork.tsx 100% <100%> (ø) ⬆️
src/utils/constants.ts 100% <100%> (ø) ⬆️
src/store/models/lightning.ts 100% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e729745...2b8ddb2. Read the comment docs.

@jamaljsr jamaljsr merged commit 2701046 into master Mar 17, 2020
@jamaljsr jamaljsr deleted the feat/eclair branch March 17, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants