-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Eclair nodes #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
- Coverage 100% 96.39% -3.61%
==========================================
Files 111 114 +3
Lines 3033 3192 +159
Branches 552 581 +29
==========================================
+ Hits 3033 3077 +44
- Misses 0 115 +115
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Eclair v0.3.3. These nodes have all of the same functionality as LND and c-lightning nodes, to deposit funds, open channels, make payments, etc.
There is only one quirk which changes the previous default behavior for all networks. Eclair will not boot up if it connects to a Bitcoin node with 0 mined blocks. You have to mine at least one block for it to not immediately exit on startup. So Polar will now automatically mine the first block for all networks.
ToDo
Steps to Test
eclair-cli getinfo
commandsScreenshots
View more screenshots