Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #1013

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Bug fixes #1013

merged 4 commits into from
Sep 27, 2024

Conversation

kelvinator07
Copy link
Contributor

Description

This PR fixes the following:

  1. updated deprecated husky command
  2. fixed error when trying to parse empty customChannelData (lnd)
  3. updated returned payinvoice amount to sats (eclair)
  4. removed obsolete version field from compose file

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c7137be) to head (35e89ee).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1013   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          151       151           
  Lines         5509      5513    +4     
  Branches      1109      1110    +1     
=========================================
+ Hits          5509      5513    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamaljsr jamaljsr self-requested a review September 26, 2024 21:39
Copy link
Owner

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes. I tested all of the changes and everything works as expected.

LGTM 🚀

@jamaljsr jamaljsr merged commit c825657 into jamaljsr:master Sep 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants