Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable configuration of hostnames for hotrod services #6782

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

w-h-a
Copy link
Contributor

@w-h-a w-h-a commented Feb 27, 2025

Which problem is this PR solving?

Resolves #6774

We want to allow users to configure the hostnames of the Hotrod services. This would allow users of the example app to run the services as separate containers.

Description of the changes

The main change is to add hostname flags for each service. We pass these in as part of the command when running the containers.

How was this change tested?

Example docker-compose usage:

hotrod-frontend:
    container_name: hotrod-frontend
    image: hotrod:0.1.0-alpha.2
    ports:
      - '8080:8080'
    command: ["frontend", "--customer-service-hostname", "hotrod-customer", "-c", "8081", "--driver-service-hostname", "hotrod-driver", "-d", "8082", "--route-service-hostname", "hotrod-route", "-r", "8083"]

hotrod-customer:
  container_name: hotrod-customer
  image: ...

Checklist

@w-h-a w-h-a requested a review from a team as a code owner February 27, 2025 15:10
@w-h-a w-h-a requested a review from albertteoh February 27, 2025 15:10
@dosubot dosubot bot added the docker Pull requests that update Docker code label Feb 27, 2025
@yurishkuro yurishkuro enabled auto-merge February 27, 2025 15:39
@yurishkuro
Copy link
Member

Thanks!

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (ce07285) to head (c035f19).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6782      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.02%     
==========================================
  Files         363      364       +1     
  Lines       20677    20690      +13     
==========================================
+ Hits        19857    19875      +18     
+ Misses        626      622       -4     
+ Partials      194      193       -1     
Flag Coverage Δ
badger_v1 9.81% <ø> (+0.05%) ⬆️
badger_v2 1.89% <ø> (+0.06%) ⬆️
cassandra-4.x-v1-manual 14.86% <ø> (+0.05%) ⬆️
cassandra-4.x-v2-auto 1.88% <ø> (+0.06%) ⬆️
cassandra-4.x-v2-manual 1.88% <ø> (+0.06%) ⬆️
cassandra-5.x-v1-manual 14.86% <ø> (+0.05%) ⬆️
cassandra-5.x-v2-auto 1.88% <ø> (+0.06%) ⬆️
cassandra-5.x-v2-manual 1.88% <ø> (+0.06%) ⬆️
elasticsearch-6.x-v1 19.19% <ø> (+0.04%) ⬆️
elasticsearch-7.x-v1 19.27% <ø> (+0.04%) ⬆️
elasticsearch-8.x-v1 19.44% <ø> (+0.04%) ⬆️
elasticsearch-8.x-v2 1.89% <ø> (+0.06%) ⬆️
grpc_v1 10.86% <ø> (+0.05%) ⬆️
grpc_v2 7.86% <ø> (+0.06%) ⬆️
kafka-3.x-v1 10.11% <ø> (-0.02%) ⬇️
kafka-3.x-v2 1.89% <ø> (+0.06%) ⬆️
memory_v2 1.89% <ø> (+0.06%) ⬆️
opensearch-1.x-v1 19.32% <ø> (+0.04%) ⬆️
opensearch-2.x-v1 19.32% <ø> (+0.04%) ⬆️
opensearch-2.x-v2 1.89% <ø> (+0.06%) ⬆️
tailsampling-processor 0.48% <ø> (-0.01%) ⬇️
unittests 94.94% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added this pull request to the merge queue Feb 27, 2025
Merged via the queue into jaegertracing:main with commit 93e0221 Feb 27, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Hotrod example can be run as four separate containers
2 participants