-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix]: update all otel collector packages #6759
Conversation
Signed-off-by: AnmolxSingh <[email protected]>
@yurishkuro please review |
Signed-off-by: AnmolxSingh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6759 +/- ##
==========================================
+ Coverage 96.02% 96.06% +0.03%
==========================================
Files 364 364
Lines 20692 20692
==========================================
+ Hits 19869 19877 +8
+ Misses 628 622 -6
+ Partials 195 193 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
unit tests are failing |
It's not what failed in the ci
|
Got it. Where could I find file where remote sampling is registered |
not sure I follow. Just run the tests that are failing and see which lines. You can also run the tests in debugger |
the tests are creating extension like this:
meanwhile |
This fixes some of the tests: @@ -35,6 +35,7 @@ func makeStorageExtension(t *testing.T, memstoreName string) component.Host {
storageExtension, err := extensionFactory.Create(
context.Background(),
extension.Settings{
+ ID: jaegerstorage.ID,
TelemetrySettings: telemetrySettings,
},
&jaegerstorage.Config{
@@ -61,6 +62,7 @@ func makeRemoteSamplingExtension(t *testing.T, cfg component.Config) component.H
samplingExtension, err := extensionFactory.Create(
context.Background(),
extension.Settings{
+ ID: remotesampling.ID,
TelemetrySettings: component.TelemetrySettings{
Logger: zap.L(),
TracerProvider: nooptrace.NewTracerProvider(), |
Signed-off-by: AnmolxSingh <[email protected]>
it complains about the type, not the random string part |
Signed-off-by: Yuri Shkuro <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test