Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stdlib iterators #6714

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Use stdlib iterators #6714

merged 7 commits into from
Feb 13, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 12, 2025

Description of the changes

  • Since we upgraded to Go 1.23 we can use standard "iter" package

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (42cd2b9) to head (d196598).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6714      +/-   ##
==========================================
+ Coverage   95.83%   96.02%   +0.19%     
==========================================
  Files         364      364              
  Lines       20699    20699              
==========================================
+ Hits        19836    19876      +40     
+ Misses        671      628      -43     
- Partials      192      195       +3     
Flag Coverage Δ
badger_v1 9.83% <ø> (+0.02%) ⬆️
badger_v2 1.82% <ø> (+<0.01%) ⬆️
cassandra-4.x-v1-manual 14.80% <ø> (+0.04%) ⬆️
cassandra-4.x-v2-auto 1.81% <ø> (+<0.01%) ⬆️
cassandra-4.x-v2-manual 1.81% <ø> (+<0.01%) ⬆️
cassandra-5.x-v1-manual 14.80% <ø> (+0.04%) ⬆️
cassandra-5.x-v2-auto 1.81% <ø> (+<0.01%) ⬆️
cassandra-5.x-v2-manual 1.81% <ø> (+<0.01%) ⬆️
elasticsearch-6.x-v1 19.13% <ø> (+0.05%) ⬆️
elasticsearch-7.x-v1 19.21% <ø> (+0.05%) ⬆️
elasticsearch-8.x-v1 19.38% <ø> (+0.05%) ⬆️
elasticsearch-8.x-v2 1.82% <ø> (+<0.01%) ⬆️
grpc_v1 10.80% <ø> (+0.03%) ⬆️
grpc_v2 7.80% <ø> (+0.02%) ⬆️
kafka-3.x-v1 10.12% <ø> (?)
kafka-3.x-v2 1.82% <ø> (+<0.01%) ⬆️
memory_v2 1.82% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 19.26% <ø> (+0.05%) ⬆️
opensearch-2.x-v1 19.26% <ø> (+0.05%) ⬆️
opensearch-2.x-v2 1.82% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.48% <ø> (+<0.01%) ⬆️
unittests 94.91% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro marked this pull request as ready for review February 12, 2025 04:21
@yurishkuro yurishkuro requested a review from a team as a code owner February 12, 2025 04:21
@dosubot dosubot bot added the area/storage label Feb 12, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) February 12, 2025 04:38
@yurishkuro yurishkuro merged commit c0f5b4b into jaegertracing:main Feb 13, 2025
55 checks passed
@yurishkuro yurishkuro deleted the iter branch February 13, 2025 00:51
yurishkuro added a commit that referenced this pull request Feb 13, 2025
## Description of the changes
- Follow-up to #6714

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants