Alias samping.thrift and clean thrift files

[Nabil-Salah]

Which problem is this PR solving?

• Redefine thrift-gen types as aliases to jaeger-idl #6617

Description of the changes

• remove unused Thrift files
• remove thrift makefile
• edit makefile
• alias samping.thrift

How was this change tested?

• make test lint

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: npm run lint and npm run test

[Nabil-Salah]

I am not seeing any aliases added

I made alias in thrift-gen/sampling/sampling.go and removed baggage.thrift generations

[yurishkuro]

suggestion: instead of editing generated file, delete it and create another one sampling_alias.go. Don't forget to run make fmt to add the license header.

[Nabil-Salah]

okay will make these updates in a second

[Nabil-Salah]

suggestion: instead of editing generated file, delete it and create another one sampling_alias.go. Don't forget to run make fmt to add the license header.

@yurishkuro
changing the name didn't update
I updated makefile take a look for that I think now as we are migrating all model types and making alias only it's okay to make this change to add these files to non generated files

[yurishkuro]

changing the name didn't update

what do you mean? mv thrift-gen/sampling/sampling.go thrift-gen/sampling/sampling_aliases.go

[Nabil-Salah]

yes when i do that it willn't get effected by make fmt

.PHONY: fmt
fmt: $(GOFUMPT)
	@echo Running import-order-cleanup on ALL_SRC ...

fmt uses ALL_SRC variable that exclude -gen folders I updated this in makefile

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (97e800d) to head (7a03949).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6630      +/-   ##
==========================================
- Coverage   95.96%   95.93%   -0.03%     
==========================================
  Files         365      365              
  Lines       20616    20616              
==========================================
- Hits        19784    19778       -6     
- Misses        634      638       +4     
- Partials      198      200       +2     

Flag	Coverage Δ
badger_v1	9.92% <ø> (ø)
badger_v2	1.84% <ø> (ø)
cassandra-4.x-v1-manual	14.93% <ø> (ø)
cassandra-4.x-v2-auto	1.83% <ø> (ø)
cassandra-4.x-v2-manual	1.83% <ø> (ø)
cassandra-5.x-v1-manual	14.93% <ø> (ø)
cassandra-5.x-v2-auto	1.83% <ø> (ø)
cassandra-5.x-v2-manual	1.83% <ø> (ø)
elasticsearch-6.x-v1	19.30% <ø> (ø)
elasticsearch-7.x-v1	19.38% <ø> (ø)
elasticsearch-8.x-v1	19.56% <ø> (ø)
elasticsearch-8.x-v2	1.84% <ø> (ø)
grpc_v1	10.90% <ø> (ø)
grpc_v2	7.89% <ø> (ø)
kafka-3.x-v1	10.21% <ø> (ø)
kafka-3.x-v2	1.84% <ø> (ø)
memory_v2	1.84% <ø> (ø)
opensearch-1.x-v1	19.44% <ø> (ø)
opensearch-2.x-v1	19.44% <ø> (ø)
opensearch-2.x-v2	1.84% <ø> (ø)
tailsampling-processor	0.48% <ø> (ø)
unittests	94.81% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.