-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Clickhouse config #6622
base: main
Are you sure you want to change the base?
Create Clickhouse config #6622
Conversation
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
Signed-off-by: adityachopra29 <[email protected]>
This is a draft pr. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6622 +/- ##
==========================================
- Coverage 96.00% 95.97% -0.04%
==========================================
Files 365 366 +1
Lines 20616 20623 +7
==========================================
Hits 19792 19792
- Misses 626 633 +7
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just realised a structure change is required. Will make it and update the pr shortly. |
What is the motivation for the specific config parameters you are introducing? It feels a bit like putting the horse in front of the carriage - we don't have an implementation of the storage yet, so how do we know which config options will even be required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin/storage/clickhouse/config.go
Outdated
type BasicAuthenticator struct { | ||
Username string `mapstructure:"username"` | ||
Password string `mapstructure:"password"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the following are required for a mini connection: 1. host 2. port 3. database 4. username 5. password.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: adityachopra29 <[email protected]>
@yurishkuro I see. I looked through the configurations for the other db storages, and saw what types of configurations jaeger was using to model config for clickhouse. But adding config as we develop is more logical. |
Which problem is this PR solving?
Description of the changes
plugin/storage/clickhouse/
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test