Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine thrift-gen types as aliases to jaeger-idl #6619

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

danish9039
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • remove auto-generated code and replace its types / functions with aliases to jaeger-idl hosted types

How was this change tested?

Checklist

@danish9039 danish9039 requested a review from a team as a code owner January 27, 2025 10:13
@danish9039 danish9039 requested a review from jkowall January 27, 2025 10:13
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (852d9b6) to head (d7d9a14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6619   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files         365      365           
  Lines       20616    20616           
=======================================
  Hits        19787    19787           
  Misses        630      630           
  Partials      199      199           
Flag Coverage Δ
badger_v1 9.92% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1-manual 15.08% <ø> (ø)
cassandra-4.x-v2-auto 1.83% <ø> (ø)
cassandra-4.x-v2-manual 1.83% <ø> (ø)
cassandra-5.x-v1-manual 15.08% <ø> (ø)
cassandra-5.x-v2-auto 1.83% <ø> (ø)
cassandra-5.x-v2-manual 1.83% <ø> (ø)
elasticsearch-6.x-v1 19.30% <ø> (ø)
elasticsearch-7.x-v1 19.38% <ø> (ø)
elasticsearch-8.x-v1 19.56% <ø> (ø)
elasticsearch-8.x-v2 1.84% <ø> (ø)
grpc_v1 11.04% <ø> (ø)
grpc_v2 7.89% <ø> (ø)
kafka-3.x-v1 10.21% <ø> (ø)
kafka-3.x-v2 1.84% <ø> (ø)
memory_v2 1.84% <ø> (ø)
opensearch-1.x-v1 19.44% <ø> (ø)
opensearch-2.x-v1 19.44% <ø> (ø)
opensearch-2.x-v2 1.84% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

you need to remove code gen steps from Mekefile.Thrift.mk

Signed-off-by: danish9039 <[email protected]>
@danish9039
Copy link
Contributor Author

you need to remove code gen steps from Mekefile.Thrift.mk

got it !

you need to remove code gen steps from Mekefile.Thrift.mk

removed code-gen steps for jaeger.thrift , agent.thrift and zipkincore.thrift

@yurishkuro yurishkuro merged commit 20bdd8d into jaegertracing:main Jan 27, 2025
55 checks passed
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants