Create a /quality-metrics endpoint #6608
Conversation
Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: cs-308-2023 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6608 +/- ##
==========================================
+ Coverage 95.98% 96.01% +0.03%
==========================================
Files 363 363
Lines 20601 20739 +138
==========================================
+ Hits 19773 19913 +140
+ Misses 632 630 -2
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: cs-308-2023 <[email protected]>
|
Hey @ADI-ROXX , I was working on this PR: Migrate DetailsCard from class based to function based component, but there's a problem that before migrating, the |
cmd/query/app/http_handler.go
Outdated
| @@ -183,7 +262,7 @@ func (aH *APIHandler) transformOTLP(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| traces, err := otlp2traces(body) | |||
| if aH.handleError(w, err, http.StatusInternalServerError) { | |||
| if aH.handleError(w, err, http.StatusBadRequest) { | |||
There was a problem hiding this comment.
this is unrelated to this PR
| @@ -80,6 +80,84 @@ type APIHandler struct { | |||
| tracer trace.TracerProvider | |||
| } | |||
|
|
|||
| type TQualityMetrics struct { | |||
There was a problem hiding this comment.
please move all new code (data types and sample data) to another package like app/qualitymetrics and only leave the handler function in this pkg
Signed-off-by: cs-308-2023 <[email protected]>
Hi @yaten2302. I don't think that this PR has much change left. However, if I feel difficulty in something, I will let you know. |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test