Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UDP ports in all-in-one #6413

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Recently there was a thread in #jaeger slack room with a user who is still using legacy SDKs that emit traces via UDP. The all-in-one configuration in Jaeger v2 currently has them disabled, which breaks backwards compatibility.

Description of the changes

  • Enable UDP ports

How was this change tested?

  • Ran go run ./cmd/jaeger to ensure configuration is accepted. The user on slack also confirmed that it worked for them.
  • Unfortunately, we do not have e2e tests for this.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (0369bea) to head (9a7facb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6413   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         368      368           
  Lines       20979    20979           
=======================================
  Hits        20196    20196           
  Misses        599      599           
  Partials      184      184           
Flag Coverage Δ
badger_v1 8.94% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1-manual 14.87% <ø> (ø)
cassandra-4.x-v2-auto 1.78% <ø> (ø)
cassandra-4.x-v2-manual 1.78% <ø> (ø)
cassandra-5.x-v1-manual 14.87% <ø> (ø)
cassandra-5.x-v2-auto 1.78% <ø> (ø)
cassandra-5.x-v2-manual 1.78% <ø> (ø)
elasticsearch-6.x-v1 18.55% <ø> (ø)
elasticsearch-7.x-v1 18.62% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.79% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.83% <ø> (-0.01%) ⬇️
grpc_v1 10.60% <ø> (ø)
grpc_v2 8.11% <ø> (+<0.01%) ⬆️
kafka-2.x-v1 9.30% <ø> (ø)
kafka-2.x-v2 1.84% <ø> (ø)
kafka-3.x-v1 9.30% <ø> (ø)
kafka-3.x-v2 1.84% <ø> (ø)
memory_v2 1.83% <ø> (ø)
opensearch-1.x-v1 18.68% <ø> (ø)
opensearch-2.x-v1 18.68% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 1.84% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro added a commit to jaegertracing/documentation that referenced this pull request Dec 25, 2024
@yurishkuro yurishkuro merged commit 41e02d7 into jaegertracing:main Dec 25, 2024
57 checks passed
@yurishkuro yurishkuro deleted the udp branch December 25, 2024 21:44
Manik2708 pushed a commit to Manik2708/jaeger that referenced this pull request Jan 5, 2025
## Which problem is this PR solving?
- Recently there was a thread in `#jaeger` slack room with a user who is
still using legacy SDKs that emit traces via UDP. The all-in-one
configuration in Jaeger v2 currently has them disabled, which breaks
backwards compatibility.

## Description of the changes
- Enable UDP ports

## How was this change tested?
- Ran `go run ./cmd/jaeger` to ensure configuration is accepted. The
user on slack also confirmed that it worked for them.
- Unfortunately, we do not have e2e tests for this.

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants