Enhance Kafka integration tests to support multiple Kafka versions #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzk1
force-pushed
the
Issue-3068-mulit-kafka-integration-test
branch
from
43aebe4 to
21b81c6
Compare
|
I 'm not sure where to record the document.... 🤔 |
yurishkuro
reviewed
Dec 24, 2024
Signed-off-by: zzzk1 <[email protected]>
zzzk1
force-pushed
the
Issue-3068-mulit-kafka-integration-test
branch
from
ffbcd21 to
47d2e03
Compare
Signed-off-by: zzzk1 <[email protected]>
zzzk1
force-pushed
the
Issue-3068-mulit-kafka-integration-test
branch
from
47d2e03 to
57f9f5a
Compare
|
@jpkrohling mention nightly jobs here: #3068 (comment), so what should we do now?😊 |
yurishkuro
reviewed
Dec 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6400 +/- ##
===========================================
+ Coverage 49.57% 96.27% +46.69%
===========================================
Files 182 367 +185
Lines 11190 20978 +9788
===========================================
+ Hits 5548 20197 +14649
+ Misses 5197 597 -4600
+ Partials 445 184 -261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:ci
Signed-off-by: zzzk1 <[email protected]>
yurishkuro
reviewed
Dec 25, 2024
| ;; | ||
| esac | ||
| done | ||
| if [ "$jaeger_version" != "v1" ] && [ "$jaeger_version" != "v2" ]; then | ||
| if [[ "$jaeger_version" != "v1" && "$jaeger_version" != "v2" ]]; then |
There was a problem hiding this comment.
don't have objection to the change, but can you elaborate why you wanted to change it?
yurishkuro
approved these changes
Dec 25, 2024
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
…aegertracing#6400) ## Which problem is this PR solving? - Resolves jaegertracing#3068 ## Description of the changes - Introduce old version kafka env - Update e2e CI script ## How was this change tested? - integration tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: zzzk1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test