[refactor] Clean up span.kind tag handling #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added
the
changelog:skip
yurishkuro
changed the title
mahadzaryab1
approved these changes
Dec 20, 2024
| ) | ||
|
|
||
| func SpanKindFromString(kind string) (SpanKind, error) { |
There was a problem hiding this comment.
should we add unit tests for this function?
| SpanKindProducer SpanKind = "producer" | ||
| SpanKindConsumer SpanKind = "consumer" | ||
| SpanKindInternal SpanKind = "internal" | ||
| SpanKindUnspecified SpanKind = "" |
There was a problem hiding this comment.
should this be "unspecified" - looks like some tests have expectations around that
There was a problem hiding this comment.
Unspecified is an OTEL value, it did not exist in OpenTracing, so I left it blank.
And in OTLP it's technically undefined which strings should be used because the values are numeric enums.
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6390 +/- ##
==========================================
+ Coverage 96.19% 96.22% +0.02%
==========================================
Files 362 362
Lines 20671 20679 +8
==========================================
+ Hits 19885 19898 +13
+ Misses 601 597 -4
+ Partials 185 184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes