Compatibility updates for v2 in README #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6316 +/- ##
==========================================
+ Coverage 96.24% 96.27% +0.03%
==========================================
Files 365 365
Lines 20907 20907
==========================================
+ Hits 20121 20129 +8
+ Misses 601 595 -6
+ Partials 185 183 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 8, 2024
README.md
Outdated
| @@ -67,7 +67,7 @@ For example, any given Jaeger installation at Uber is typically processing sever | |||
|
|
|||
| ### Relationship with OpenTelemetry | |||
There was a problem hiding this comment.
Hm, I recently removed this section altogether, moved it to the documentation.
https://www.jaegertracing.io/docs/next-release-v2/#relationship-with-opentelemetry
yurishkuro
reviewed
Dec 8, 2024
|
@jkowall can you update per comments? |
…nsistently Signed-off-by: Jonah Kowall <[email protected]>
|
Ωconflicts w/ main |
Signed-off-by: Jonah Kowall <[email protected]>
jkowall
added
the
changelog:skip
yurishkuro
approved these changes
Dec 23, 2024
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
## Which problem is this PR solving? Addresses part of jaegertracing/documentation#117 ## Description of the changes Update text to match Jaeger v2 ## How was this change tested? Not tested ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits --------- Signed-off-by: Jonah Kowall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Addresses part of jaegertracing/documentation#117
Description of the changes
Update text to match Jaeger v2
How was this change tested?
Not tested
Checklist