Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible null pointer deference #6184

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Conversation

vaidikcode
Copy link
Contributor

@vaidikcode vaidikcode commented Nov 9, 2024

Signed-off-by: vaidikcode [email protected]

Which problem is this PR solving?

Description of the changes

  • This will cause a null pointer exception if trace is appended without the if block being executed.

How was this change tested?

Checklist

Signed-off-by: vaidikcode <[email protected]>
@vaidikcode vaidikcode requested a review from a team as a code owner November 9, 2024 18:01
@dosubot dosubot bot added the bug label Nov 9, 2024
@yurishkuro yurishkuro changed the title Null pointer deference fix Fix possible null pointer deference Nov 10, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) November 10, 2024 17:46
@yurishkuro yurishkuro disabled auto-merge November 10, 2024 17:47
@yurishkuro yurishkuro enabled auto-merge (squash) November 10, 2024 17:47
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (8441654) to head (ed66f9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6184   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         354      354           
  Lines       20126    20126           
=======================================
  Hits        19420    19420           
  Misses        522      522           
  Partials      184      184           
Flag Coverage Δ
badger_v1 8.31% <0.00%> (ø)
badger_v2 1.67% <0.00%> (ø)
cassandra-4.x-v1 14.39% <0.00%> (ø)
cassandra-4.x-v2 1.61% <0.00%> (ø)
cassandra-5.x-v1 14.39% <0.00%> (ø)
cassandra-5.x-v2 1.61% <0.00%> (ø)
elasticsearch-6.x-v1 18.60% <0.00%> (ø)
elasticsearch-7.x-v1 18.67% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.85% <0.00%> (ø)
elasticsearch-8.x-v2 1.66% <0.00%> (ø)
grpc_v1 9.48% <100.00%> (ø)
grpc_v2 7.00% <0.00%> (ø)
kafka-v1 8.88% <0.00%> (ø)
kafka-v2 1.67% <0.00%> (ø)
memory_v2 1.67% <0.00%> (ø)
opensearch-1.x-v1 18.72% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v1 18.72% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <0.00%> (+0.01%) ⬆️
tailsampling-processor 0.46% <0.00%> (ø)
unittests 95.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit c88e0f6 into jaegertracing:main Nov 10, 2024
50 checks passed
@vaidikcode vaidikcode deleted the Fix branch January 8, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Possible panic: nil pointer dereference
2 participants