Added unit tests in pkg/es/config #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yurishkuro
reviewed
Aug 8, 2024
There was a problem hiding this comment.
you need to add a goleak test, like this: https://github.com/jaegertracing/jaeger/blob/4220d62cf3e2f18356c8504666ff43a1d838c241/pkg/version/package_test.go
yurishkuro
added
the
changelog:test
|
Nit: avoid using description like |
yurishkuro
reviewed
Aug 8, 2024
Nabil-Salah
force-pushed
the
add_pkg_es_config_tests
branch
from
3490525 to
51713cd
Compare
|
looks like your new tests are leaking goroutines. Make sure you always close ES clients properly. |
Signed-off-by: nabil salah <[email protected]>
Nabil-Salah
force-pushed
the
add_pkg_es_config_tests
branch
from
d546eaa to
360fa26
Compare
done now |
|
Thanks! |
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 13, 2024
## Which problem is this PR solving? Part of: jaegertracing#5068 ## Description of the changes - This commit adds tests for the `pkg/es/config` package. ## How was this change tested? - `make test` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: nabil salah <[email protected]> Signed-off-by: Jared Tan <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 14, 2024
## Which problem is this PR solving? Part of: jaegertracing#5068 ## Description of the changes - This commit adds tests for the `pkg/es/config` package. ## How was this change tested? - `make test` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: nabil salah <[email protected]> Signed-off-by: Jared Tan <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
## Which problem is this PR solving? Part of: jaegertracing#5068 ## Description of the changes - This commit adds tests for the `pkg/es/config` package. ## How was this change tested? - `make test` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: nabil salah <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Part of: #5068
Description of the changes
pkg/es/configpackage.How was this change tested?
make testChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test