Enable Lint Rule: line-length-limit

[varshith257]

Which problem is this PR solving?

• Part of Enable more revive linter rules #5506

Description of the changes

• Refactored the files to fix the lint of line-length limit

How was this change tested?

• make lint

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[varshith257]

@yurishkuro I have used the golines library to fix it with the following command:

golines -m 80 -w .

It has fixed most of it but still emits the lint errors for comments. Can comments also need fixes or add ignore?

[codecov]

Codecov Report

Attention: Patch coverage is 97.36973% with 53 lines in your changes missing coverage. Please review.

Project coverage is 96.18%. Comparing base (52473e7) to head (b33e98c).

Files	Patch %	Lines
cmd/anonymizer/app/query/query.go	0.00%	18 Missing ⚠️
cmd/collector/app/collector.go	76.66%	7 Missing ⚠️
cmd/ingester/app/consumer/consumer.go	88.23%	6 Missing ⚠️
cmd/query/app/server.go	92.68%	4 Missing and 2 partials ⚠️
cmd/ingester/app/builder/builder.go	16.66%	5 Missing ⚠️
...ger/internal/exporters/storageexporter/exporter.go	42.85%	4 Missing ⚠️
cmd/query/app/static_handler.go	93.75%	4 Missing ⚠️
cmd/agent/app/testutils/mock_grpc_collector.go	0.00%	1 Missing ⚠️
cmd/collector/app/server/test.go	50.00%	1 Missing ⚠️
pkg/cassandra/config/config.go	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5540      +/-   ##
==========================================
- Coverage   96.20%   96.18%   -0.02%     
==========================================
  Files         327      327              
  Lines       16007    18719    +2712     
==========================================
+ Hits        15399    18005    +2606     
- Misses        432      538     +106     
  Partials      176      176              

Flag	Coverage Δ
badger_v1	8.07% <0.85%> (+0.01%)	⬆️
badger_v2	1.77% <1.69%> (-0.17%)	⬇️
cassandra-3.x-v1	16.50% <6.81%> (+0.05%)	⬆️
cassandra-3.x-v2	1.70% <1.69%> (-0.16%)	⬇️
cassandra-4.x-v1	16.50% <6.81%> (+0.05%)	⬆️
cassandra-4.x-v2	1.70% <1.69%> (-0.16%)	⬇️
elasticsearch-7-v1	19.07% <1.42%> (+0.18%)	⬆️
elasticsearch-8-v1	19.24% <1.42%> (+0.15%)	⬆️
elasticsearch-8-v2	19.24% <1.42%> (+0.15%)	⬆️
grpc_v1	9.13% <2.55%> (-0.34%)	⬇️
grpc_v2	7.03% <5.08%> (-0.50%)	⬇️
kafka	9.85% <30.39%> (+0.08%)	⬆️
opensearch-1-v1	19.14% <1.42%> (+0.19%)	⬆️
opensearch-2-v1	19.14% <1.42%> (+0.19%)	⬆️
opensearch-2-v2	19.15% <1.42%> (+0.20%)	⬆️
unittests	93.93% <96.87%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

Sorry, but I am not going to review 519 files. There was a clear comment in the config that the default length is not acceptable to us.

[varshith257]

Yes, the config contains 80 is too small :)

Okay, will divide it into multiple PRS. What could be an acceptable line length limit? I am thinking of 120 which I have seen in a Google article on the recommended line length limit for Golang or any suggestions?

[yurishkuro]

I am thinking of 120 which I have seen in a Google article on the recommended line length limit for Golang or any suggestions?

How many breaks would be detected with 120?

[varshith257]

Ok, I have made changes and here are about 80 and 120 lll changes will reflect in the codebase:

80 lll - 18k+ lines and 519 files changed
120 lll - 2708 lines and 213 files changed

@yurishkuro Maybe we can go with 120. WDYT?

[yurishkuro]

213 files is still too many, not worth the effort.

[varshith257]

@yurishkuro For 150 there are 81 files changed

[yurishkuro]

still not worth it. I don't want to spend an hour reviewing such changes that provide little benefit. I usually try to fix long lines when making changes in the code, as a side effect.

[varshith257]

ok! Closing