Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lint Rules: early-return & indent-error-flow #5526

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

FlamingSaint
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Enabled early-return & indent-error-flow in revive linter
  • Simplified if-else blocks

How was this change tested?

  • make lint make test

Checklist

@FlamingSaint FlamingSaint requested a review from a team as a code owner June 4, 2024 00:00
@FlamingSaint FlamingSaint requested a review from joe-elliott June 4, 2024 00:00
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (b295383) to head (bd884c3).

Files Patch % Lines
pkg/es/client/index_client.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5526       +/-   ##
===========================================
+ Coverage   54.24%   96.19%   +41.94%     
===========================================
  Files         161      327      +166     
  Lines        8369    16007     +7638     
===========================================
+ Hits         4540    15398    +10858     
+ Misses       3383      433     -2950     
+ Partials      446      176      -270     
Flag Coverage Δ
badger_v1 8.05% <0.00%> (+<0.01%) ⬆️
badger_v2 1.93% <0.00%> (+<0.01%) ⬆️
cassandra-3.x-v1 16.45% <16.66%> (+<0.01%) ⬆️
cassandra-3.x-v2 1.85% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 16.45% <16.66%> (+<0.01%) ⬆️
cassandra-4.x-v2 1.85% <0.00%> (+<0.01%) ⬆️
elasticsearch-7-v1 18.89% <0.00%> (+<0.01%) ⬆️
elasticsearch-8-v1 19.09% <0.00%> (+<0.01%) ⬆️
elasticsearch-8-v2 19.09% <0.00%> (+0.01%) ⬆️
grpc_v1 9.47% <0.00%> (-0.01%) ⬇️
grpc_v2 7.53% <0.00%> (+<0.01%) ⬆️
kafka 9.77% <16.66%> (-0.01%) ⬇️
opensearch-1-v1 18.93% <0.00%> (-0.01%) ⬇️
opensearch-2-v1 18.94% <0.00%> (+<0.01%) ⬆️
opensearch-2-v2 18.93% <0.00%> (+<0.01%) ⬆️
unittests 93.89% <96.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 4, 2024
@yurishkuro yurishkuro merged commit 6b95711 into jaegertracing:main Jun 4, 2024
39 checks passed
@FlamingSaint FlamingSaint deleted the linter_3 branch June 5, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants