Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing mermaid markup #5413

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Previous PR did not include markup and the diagram is not rendering correctly

Description of the changes

  • Add markup

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label May 3, 2024
@yurishkuro yurishkuro requested a review from a team as a code owner May 3, 2024 22:24
@yurishkuro yurishkuro requested a review from pavolloffay May 3, 2024 22:24
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (8f9a9e7) to head (3d75182).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5413      +/-   ##
==========================================
+ Coverage   94.50%   94.55%   +0.04%     
==========================================
  Files         346      346              
  Lines       16945    16945              
==========================================
+ Hits        16014    16022       +8     
+ Misses        729      722       -7     
+ Partials      202      201       -1     
Flag Coverage Δ
badger_v1 10.29% <ø> (ø)
badger_v2 6.60% <ø> (+0.05%) ⬆️
cassandra-3.x 18.14% <ø> (ø)
cassandra-4.x 18.14% <ø> (ø)
elasticsearch-5.x 5.89% <ø> (?)
grpc_v1 12.62% <ø> (+0.02%) ⬆️
grpc_v2 11.52% <ø> (-0.02%) ⬇️
kafka 9.96% <ø> (ø)
opensearch-1.x 5.89% <ø> (ø)
opensearch-2.x 5.89% <ø> (ø)
unittests 91.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 13cbaed into jaegertracing:main May 4, 2024
36 of 39 checks passed
@yurishkuro yurishkuro deleted the mermaid branch May 4, 2024 00:18
Pushkarm029 pushed a commit to Pushkarm029/jaeger that referenced this pull request May 4, 2024
## Which problem is this PR solving?
- Previous PR did not include markup and the diagram is not rendering
correctly

## Description of the changes
- Add markup

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants