Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking change in upgrading OTEL Collector #5314

Merged

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Mar 31, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@lekaf974 lekaf974 requested a review from a team as a code owner March 31, 2024 01:50
@lekaf974 lekaf974 requested a review from albertteoh March 31, 2024 01:50
go.mod Outdated Show resolved Hide resolved
@lekaf974 lekaf974 force-pushed the fix/opentelemetry-receiver-error branch from 16bc45b to 31b3adb Compare March 31, 2024 22:27
@yurishkuro
Copy link
Member

please make sure make test succeeds locally before submitting for review

@lekaf974 lekaf974 force-pushed the fix/opentelemetry-receiver-error branch 4 times, most recently from 2634bb9 to 5e53292 Compare April 1, 2024 01:05
@lekaf974
Copy link
Contributor Author

lekaf974 commented Apr 1, 2024

please make sure make test succeeds locally before submitting for review

make test is passing locally

Ready for a new review

@lekaf974 lekaf974 force-pushed the fix/opentelemetry-receiver-error branch from 5e53292 to ec0fd05 Compare April 1, 2024 01:41
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (f18416a) to head (8c7aba0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5314      +/-   ##
==========================================
+ Coverage   95.15%   95.16%   +0.01%     
==========================================
  Files         340      340              
  Lines       16666    16666              
==========================================
+ Hits        15858    15860       +2     
+ Misses        617      616       -1     
+ Partials      191      190       -1     
Flag Coverage Δ
badger 12.25% <ø> (ø)
cassandra-3.x 21.14% <ø> (ø)
cassandra-4.x 21.14% <ø> (ø)
elasticsearch-5.x 17.70% <ø> (ø)
elasticsearch-6.x 17.68% <ø> (-0.02%) ⬇️
elasticsearch-7.x 17.76% <ø> (+0.01%) ⬆️
elasticsearch-8.x 17.83% <ø> (ø)
grpc 11.56% <100.00%> (-0.04%) ⬇️
kafka 11.84% <ø> (ø)
opensearch-1.x 17.75% <ø> (-0.02%) ⬇️
opensearch-2.x 17.76% <ø> (ø)
unittests 92.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Apr 1, 2024
@lekaf974 lekaf974 force-pushed the fix/opentelemetry-receiver-error branch from ec0fd05 to 8c7aba0 Compare April 1, 2024 14:48
@yurishkuro yurishkuro enabled auto-merge (squash) April 2, 2024 00:57
@yurishkuro yurishkuro merged commit 4482086 into jaegertracing:main Apr 2, 2024
37 checks passed
@yurishkuro
Copy link
Member

@lekaf974 thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix breaking changes in upgrading OTEL Collector
2 participants