Add goleak check in pkg/cassandra/gocql/testutils #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danish siddiqui <[email protected]>
Signed-off-by: danish siddiqui <[email protected]>
akagami-harsh
approved these changes
Mar 27, 2024
| @@ -79,3 +80,7 @@ func TestUDTTestCase(t *testing.T) { | |||
|
|
|||
| testCase.Run(t) | |||
| } | |||
|
|
|||
| func TestMain(m *testing.M) { | |||
| goleak.VerifyTestMain(m) | |||
There was a problem hiding this comment.
don't use this directly, call testutils.VerifyGoLeaks form pkg/testutils as did in this PR
There was a problem hiding this comment.
thanks @akagami-harsh ,looking into it
Signed-off-by: danish siddiqui <[email protected]>
Signed-off-by: danish siddiqui <[email protected]>
yurishkuro
added
the
changelog:test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5304 +/- ##
=======================================
Coverage 95.08% 95.08%
=======================================
Files 340 340
Lines 16626 16626
=======================================
Hits 15809 15809
+ Misses 629 628 -1
- Partials 188 189 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
changed the title
yurishkuro
approved these changes
Mar 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
pkg/cassandra/gocql/testutilsHow was this change tested?
make testChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test