Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CODEOWNERS to .github/ #5212

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

yurishkuro
Copy link
Member

It was unnecessarily cluttering root directory, but it's purely GitHub's file.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner February 19, 2024 18:09
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73835c4) 94.43% compared to head (6d8c70f) 94.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5212   +/-   ##
=======================================
  Coverage   94.43%   94.44%           
=======================================
  Files         334      334           
  Lines       19254    19254           
=======================================
+ Hits        18183    18184    +1     
  Misses        882      882           
+ Partials      189      188    -1     
Flag Coverage Δ
cassandra-3.x 25.53% <ø> (ø)
cassandra-4.x 25.53% <ø> (ø)
elasticsearch-5.x 19.81% <ø> (-0.02%) ⬇️
elasticsearch-6.x 19.81% <ø> (ø)
elasticsearch-7.x 19.96% <ø> (ø)
elasticsearch-8.x 20.03% <ø> (-0.02%) ⬇️
grpc-badger 19.46% <ø> (ø)
kafka 14.06% <ø> (ø)
opensearch-1.x 19.94% <ø> (-0.02%) ⬇️
opensearch-2.x 19.96% <ø> (+0.01%) ⬆️
unittests 92.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@yurishkuro yurishkuro merged commit 6f7d9a1 into jaegertracing:main Feb 19, 2024
34 of 36 checks passed
@yurishkuro yurishkuro deleted the mv-codeowners branch February 19, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants