Add test for storage-exporter

[chirag-ghosh]

Which problem is this PR solving?

• Resolves part of Implement missing unit tests #5068

Description of the changes

• Add tests to storageexporter package

How was this change tested?

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[chirag-ghosh]

The config is set now. However, I am unable to find a way to properly set the Component Host.

[yurishkuro]

Did you check how exporters are tested in opentelemetry-collector? We should use the same patterns.

[chirag-ghosh]

The exporters in opentelemetry-collector were using the noop component host from componenttest package. Our exporter however required a host with custom configs. I have tried to do that. Please review.

[github-actions]

Test Results

2 086 tests  +3   2 076 ✅ +3   1m 8s ⏱️ ±0s
  220 suites ±0      10 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e99083a. ± Comparison against base commit 42304f3.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42304f3) 95.59% compared to head (e99083a) 95.55%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5078      +/-   ##
==========================================
- Coverage   95.59%   95.55%   -0.04%     
==========================================
  Files         316      319       +3     
  Lines       18322    18376      +54     
==========================================
+ Hits        17515    17560      +45     
- Misses        648      654       +6     
- Partials      159      162       +3     

Flag	Coverage Δ
cassandra-3.x	25.59% <ø> (ø)
cassandra-4.x	25.59% <ø> (ø)
elasticsearch-5.x	19.87% <ø> (ø)
elasticsearch-6.x	19.87% <ø> (+0.01%)	⬆️
elasticsearch-7.x	20.01% <ø> (ø)
elasticsearch-8.x	20.10% <ø> (ø)
grpc-badger	19.51% <ø> (ø)
kafka	14.10% <ø> (ø)
opensearch-1.x	19.99% <ø> (ø)
opensearch-2.x	20.01% <ø> (ø)
unittests	93.25% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

Looks almost ready. See some comments above, and also there are a few error returns that are not covered by tests, can you add them? They look fairly easy to simulate (except f.CreateSpanWriter() call, this might be tricky right now)

[chirag-ghosh]

Do you mean like intentionally introducing errors and then test that errors are indeed thrown?

[yurishkuro]

Thanks!