Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goroutine leak in cmd/agent/app/reporter/grpc #5075

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

akagami-harsh
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • fixed goroutine leaks in cmd/agent/app/reporter/grpc and also added a goleak check

How was this change tested?

  • go test

Checklist

Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
@akagami-harsh akagami-harsh requested a review from a team as a code owner January 3, 2024 13:35
Copy link

github-actions bot commented Jan 3, 2024

Test Results

2 053 tests  ±0   2 043 ✅ ±0   1m 8s ⏱️ -1s
  219 suites ±0      10 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 4db2698. ± Comparison against base commit e85c8fb.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e85c8fb) 95.62% compared to head (4db2698) 95.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5075      +/-   ##
==========================================
- Coverage   95.62%   95.60%   -0.02%     
==========================================
  Files         314      314              
  Lines       18296    18302       +6     
==========================================
+ Hits        17495    17498       +3     
- Misses        642      644       +2     
- Partials      159      160       +1     
Flag Coverage Δ
cassandra-3.x 25.59% <ø> (ø)
cassandra-4.x 25.59% <ø> (ø)
elasticsearch-5.x 19.87% <ø> (ø)
elasticsearch-6.x 19.87% <ø> (ø)
elasticsearch-7.x 19.99% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.10% <ø> (ø)
grpc-badger 19.49% <ø> (-0.02%) ⬇️
kafka 14.10% <ø> (ø)
opensearch-1.x 20.01% <ø> (ø)
opensearch-2.x 20.01% <ø> (ø)
unittests 93.29% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Jan 3, 2024
@yurishkuro
Copy link
Member

Thanks!

@yurishkuro yurishkuro merged commit 6c70344 into jaegertracing:main Jan 3, 2024
39 of 40 checks passed
@akagami-harsh akagami-harsh deleted the add-goleak-check branch January 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants