Add unit tests in cmd/jaeger/internal

cmd/jaeger/internal/command.go

@@ -9,6 +9,7 @@
 	"log"
 
 	"github.com/spf13/cobra"
+	"github.com/spf13/pflag"
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/otelcol"
 
@@ -41,15 +42,7 @@
 	otelRunE := cmd.RunE
 	cmd.RunE = func(cmd *cobra.Command, args []string) error {
 		configFlag := cmd.Flag("config")
-		if !configFlag.Changed {
-			log.Print("No '--config' flags detected, using default All-in-One configuration with memory storage.")
-			log.Print("To customize All-in-One behavior, pass a proper configuration.")
-			data, err := yamlAllInOne.ReadFile("all-in-one.yaml")
-			if err != nil {
-				return fmt.Errorf("cannot read embedded all-in-one configuration: %w", err)
-			}
-			configFlag.Value.Set("yaml:" + string(data))
-		}
+		handleConfigFlag(configFlag, args)
 		return otelRunE(cmd, args)
 	}
 
@@ -58,3 +51,16 @@
 
 	return cmd
 }
+
+func handleConfigFlag(configFlag *pflag.Flag, args []string) error {
+	if !configFlag.Changed {
+		log.Print("No '--config' flags detected, using default All-in-One configuration with memory storage.")
+		log.Print("To customize All-in-One behavior, pass a proper configuration.")
+		data, err := yamlAllInOne.ReadFile("all-in-one.yaml")
+		if err != nil {
+			return fmt.Errorf("cannot read embedded all-in-one configuration: %w", err)
+		}
+		configFlag.Value.Set("yaml:" + string(data))
+	}
+	return nil
+}

cmd/jaeger/internal/command_test.go

@@ -0,0 +1,37 @@
+// Copyright (c) 2024 The Jaeger Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package internal
+
+import (
+	"testing"
+
+	"github.com/spf13/pflag"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestCommand(t *testing.T) {
+	cmd := Command()
+	assert.NotNil(t, cmd, "Command() should return a non-nil *cobra.Command instance")
+	assert.NotNil(t, cmd.RunE, "Command should have RunE function set")
+}
+
+func TestHandleConfigFlag(t *testing.T) {
+	configFlag := pflag.NewFlagSet("testFlagSet", pflag.ContinueOnError)
+	configFlag.String("config", "", "Path to the config file")
+
+	err := handleConfigFlag(configFlag.Lookup("config"), []string{})
+	require.NoError(t, err)
+}

cmd/jaeger/internal/components_test.go

@@ -0,0 +1,37 @@
+// Copyright (c) 2024 The Jaeger Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package internal
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestComponents(t *testing.T) {
+	factories, err := components()
+
+	require.NoError(t, err)
+
+	assert.NotNil(t, factories.Extensions)
+	assert.NotNil(t, factories.Receivers)
+	assert.NotNil(t, factories.Exporters)
+	assert.NotNil(t, factories.Processors)
+	assert.NotNil(t, factories.Connectors)
+
+	_, jaegerReceiverFactoryExists := factories.Receivers["jaeger"]
+	assert.True(t, jaegerReceiverFactoryExists)
+}

cmd/jaeger/internal/package_test.go

@@ -0,0 +1,25 @@
+// Copyright (c) 2024 The Jaeger Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package internal
+
+import (
+	"testing"
+
+	"github.com/jaegertracing/jaeger/pkg/testutils"
+)
+
+func TestMain(m *testing.M) {
+	testutils.VerifyGoLeaks(m)
+}