Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goroutine leaks in some packages #5038

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

akagami-harsh
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • fix goroutine leaks in some package and add goleak check

How was this change tested?

  • go test

@akagami-harsh akagami-harsh requested a review from a team as a code owner December 25, 2023 20:53
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d1cc9f) 52.59% compared to head (36a590a) 95.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5038       +/-   ##
===========================================
+ Coverage   52.59%   95.60%   +43.00%     
===========================================
  Files         145      319      +174     
  Lines        8599    18794    +10195     
===========================================
+ Hits         4523    17968    +13445     
+ Misses       3728      663     -3065     
+ Partials      348      163      -185     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.88% <ø> (ø)
elasticsearch-6.x 19.88% <ø> (ø)
elasticsearch-7.x 20.00% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.11% <ø> (ø)
grpc-badger 19.50% <ø> (ø)
kafka 14.10% <ø> (ø)
opensearch-1.x 20.00% <ø> (-0.02%) ⬇️
opensearch-2.x 20.02% <ø> (ø)
unittests 93.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
Thanks!

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Dec 25, 2023
@yurishkuro yurishkuro enabled auto-merge (squash) December 25, 2023 21:15
@yurishkuro yurishkuro merged commit 16985d4 into jaegertracing:main Dec 25, 2023
37 of 38 checks passed
@akagami-harsh akagami-harsh deleted the fix-goroutine-leaks branch December 25, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants