Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable errorlint linter and fix errors #5028

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Enable errorlint linter and fix errors #5028

merged 4 commits into from
Dec 23, 2023

Conversation

1-8
Copy link
Contributor

@1-8 1-8 commented Dec 22, 2023

Which problem is this PR solving?

Resolves #5027

Description of the changes

  • Use %w when wrapping errors
  • use errors.Is and errors.As instead of explicit cast or comparison
  • Fix a bug 249c959 where direct and wrapped io.EOF were conflicting
  • Enable error linting

How was this change tested?

Checklist

@1-8 1-8 requested a review from a team as a code owner December 22, 2023 10:13
@1-8 1-8 requested a review from yurishkuro December 22, 2023 10:13
@akagami-harsh
Copy link
Member

@1-8 , DCO is failing on your PR. Follow the CONTRIBUTING_GUIDELINES. You can read more about DCO here

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (db20c5b) 95.62% compared to head (6906382) 95.60%.

Files Patch % Lines
cmd/query/app/server.go 0.00% 0 Missing and 1 partial ⚠️
plugin/storage/badger/samplingstore/storage.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5028      +/-   ##
==========================================
- Coverage   95.62%   95.60%   -0.02%     
==========================================
  Files         319      319              
  Lines       18793    18800       +7     
==========================================
+ Hits        17971    17974       +3     
- Misses        660      663       +3     
- Partials      162      163       +1     
Flag Coverage Δ
cassandra-3.x 25.61% <33.33%> (ø)
cassandra-4.x 25.61% <33.33%> (ø)
elasticsearch-5.x 19.87% <0.00%> (ø)
elasticsearch-6.x 19.87% <0.00%> (ø)
elasticsearch-7.x 20.02% <0.00%> (ø)
elasticsearch-8.x 20.11% <0.00%> (ø)
grpc-badger 19.51% <30.00%> (-0.01%) ⬇️
kafka 14.10% <0.00%> (ø)
opensearch-1.x 20.02% <0.00%> (+0.01%) ⬆️
opensearch-2.x 20.02% <0.00%> (ø)
unittests 93.35% <96.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1-8
Copy link
Contributor Author

1-8 commented Dec 22, 2023

@1-8 , DCO is failing on your PR. Follow the CONTRIBUTING_GUIDELINES. You can read more about DCO here

Thank you for pointing out the DCO issue. I've completed the signoff.

@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Dec 22, 2023
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 94a97ca into jaegertracing:main Dec 23, 2023
37 checks passed
@yurishkuro
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable errorlint linter
3 participants