-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable errorlint linter and fix errors #5028
Conversation
@1-8 , |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5028 +/- ##
==========================================
- Coverage 95.62% 95.60% -0.02%
==========================================
Files 319 319
Lines 18793 18800 +7
==========================================
+ Hits 17971 17974 +3
- Misses 660 663 +3
- Partials 162 163 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: 1-8 <[email protected]>
Thank you for pointing out the DCO issue. I've completed the signoff. |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Thank you! |
Which problem is this PR solving?
Resolves #5027
Description of the changes
%w
when wrapping errorserrors.Is
anderrors.As
instead of explicit cast or comparisonHow was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test