Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.50.0 #4804

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Conversation

albertteoh
Copy link
Contributor

Updates changelog, release.md and jaeger-ui submodule for v1.50.0

Checklist

@albertteoh albertteoh requested a review from a team as a code owner October 5, 2023 20:23
@albertteoh albertteoh requested a review from jkowall October 5, 2023 20:23
CHANGELOG.md Outdated
### UI Changes

[comment]: <> (TODO: update URL)
* UI pinned to version [1.34.0](https://github.com/jaegertracing/jaeger-ui/blob/main/CHANGELOG.md#v1330-2023-08-06).
Copy link
Contributor Author

@albertteoh albertteoh Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@albertteoh albertteoh Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in: f6b60e1 and f0a89e2

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Files Coverage Δ
cmd/agent/app/configmanager/grpc/manager.go 100.00% <100.00%> (ø)
cmd/agent/app/configmanager/metrics.go 100.00% <100.00%> (ø)
cmd/agent/app/processors/thrift_processor.go 100.00% <100.00%> (ø)
cmd/agent/app/reporter/flags.go 100.00% <ø> (ø)
cmd/agent/app/reporter/grpc/builder.go 95.38% <100.00%> (+0.07%) ⬆️
cmd/agent/app/reporter/grpc/collector_proxy.go 100.00% <100.00%> (ø)
cmd/agent/app/reporter/grpc/reporter.go 100.00% <100.00%> (ø)
cmd/agent/app/reporter/reporter.go 100.00% <100.00%> (ø)
cmd/agent/app/testutils/in_memory_reporter.go 100.00% <100.00%> (ø)
cmd/collector/app/collector.go 87.90% <100.00%> (ø)
... and 65 more

... and 27 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

yurishkuro
yurishkuro previously approved these changes Oct 5, 2023
@albertteoh albertteoh enabled auto-merge (squash) October 6, 2023 02:44
@albertteoh albertteoh disabled auto-merge October 6, 2023 02:44
@yurishkuro
Copy link
Member

Strange that build started failing in this PR only, but here's a fix: #4807.

@albertteoh
Copy link
Contributor Author

Checks passed with a false positive codecov check, @yurishkuro.

@yurishkuro yurishkuro merged commit da7a5ab into jaegertracing:main Oct 6, 2023
@albertteoh albertteoh deleted the release-v1.50.0 branch October 6, 2023 09:34
@yurishkuro
Copy link
Member

My guess codecov is having a bad day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants