Add *.kerberos.disable-fast-negotiation option to Kafka consumer #4520
Conversation
Signed-off-by: bugslayer-332 <[email protected]>
pkg/kafka/auth/options.go
Outdated
| flagSet.Bool( | ||
| configPrefix+kerberosPrefix+suffixKerberosDisablePAFXFAST, | ||
| defaultKerberosDisablePAFXFast, | ||
| "Disable FAST negotiation when not supported by KDC's like Active Directory") |
There was a problem hiding this comment.
Q: why are the variables in the code have additional "PA FX" prefix? Is there semantic difference between PF-FX-FAST and just FAST? (it would be useful to include a link to the spec in the help text)
There was a problem hiding this comment.
So the additional PA FX refers to the cookie used. I considered naming the variable like that because they were done the same way in the sarama library. There is not a logical difference between both so we can consider naming it FAST. Whats your say?
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4520 +/- ##
==========================================
- Coverage 97.08% 97.04% -0.04%
==========================================
Files 300 300
Lines 17813 17813
==========================================
- Hits 17293 17287 -6
- Misses 417 421 +4
- Partials 103 105 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
changed the title
…gertracing#4520) ## Which problem is this PR solving? - Solves jaegertracing#2744 ## Short description of the changes - Added a variable in KerberosConfig struct and configured it - Added flags and the configuration for the same --------- Signed-off-by: bugslayer-332 <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: bugslayer-332 <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: KevinSchneider <[email protected]>
Which problem is this PR solving?
Short description of the changes