Add GO param to Makefile #4337
Add GO param to Makefile #4337
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4337 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 300 300
Lines 17697 17697
=======================================
+ Hits 17181 17182 +1
+ Misses 415 414 -1
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -1,6 +1,7 @@ | |||
| SHELL := /bin/bash | |||
| JAEGER_IMPORT_PATH = github.com/jaegertracing/jaeger | |||
| STORAGE_PKGS = ./plugin/storage/integration/... | |||
| GO = go | |||
There was a problem hiding this comment.
What do you think about using ?=? It means users can export GO=gotip just once, then make test each time during development, instead of needing to always run make test GO=gotip.
It also offers the option of make test GO=gotip if users don't wish to "permanently" set their GO env var.
There was a problem hiding this comment.
I personally don't like such auto-import of env vars, who knows what else is in there...
gocommand was hardcoded, making it difficult to run withgotip. Now can domake test GO=gotip