Feature: Added Support accepting OTLP via Kafka #4299
Conversation
plugin/storage/kafka/unmarshaller.go
Outdated
| newSpan := &model.Span{} | ||
| spans := []*model.Span{newSpan} | ||
| err := proto.Unmarshal(msg, newSpan) | ||
| return newSpan, err | ||
|
|
||
| return spans, err |
There was a problem hiding this comment.
newSpan := &model.Span{}
err := proto.Unmarshal(msg, newSpan)
return []*model.Span{newSpan}, err
plugin/storage/kafka/options.go
Outdated
| @@ -34,6 +34,10 @@ const ( | |||
| EncodingProto = "protobuf" | |||
| // EncodingZipkinThrift is used for spans encoded as Zipkin Thrift. | |||
There was a problem hiding this comment.
| // EncodingZipkinThrift is used for spans encoded as Zipkin Thrift. | |
| // EncodingZipkinThrift is used for spans encoded as Zipkin Thrift array. |
plugin/storage/kafka/options.go
Outdated
| // EncodingOtlpJSON is used for spans encoded as OTLP JSON. | ||
| EncodingOtlpJSON = "otlp-json" | ||
| // EncodingOtlpProto is used for spans encoded as OTLP Proto. | ||
| EncodingOtlpProto = "otlp-proto" |
There was a problem hiding this comment.
add to description of encoding flag
plugin/storage/kafka/options.go
Outdated
| @@ -34,6 +34,10 @@ const ( | |||
| EncodingProto = "protobuf" | |||
| // EncodingZipkinThrift is used for spans encoded as Zipkin Thrift. | |||
| EncodingZipkinThrift = "zipkin-thrift" | |||
| // EncodingOtlpJSON is used for spans encoded as OTLP JSON. | |||
There was a problem hiding this comment.
clarify which Protobuf type is expected in the Kafka message
There was a problem hiding this comment.
Could you tell me about Protobuf type?
Is it mean Protobuf Encoding type?
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#binary-protobuf-encoding
|
@yurishkuro |
|
please resolve merge conflicts |
|
Sorry,,,, A new PR has been created because a PR with no commits cannot be reopened. |
Which problem is this PR solving?
Short description of the changes