Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp for share #4287

Closed
wants to merge 1 commit into from
Closed

Conversation

metapox
Copy link

@metapox metapox commented Mar 10, 2023

Which problem is this PR solving?

Short description of the changes

#3949

@yurishkuro
Copy link
Member

There is already similar PR #4049, this one does not add anything new, and still has the same issue of not being able to handle batches spans that can be produced by OTEL Collector.

@metapox
Copy link
Author

metapox commented Mar 10, 2023

Thank you for comment

I had already read this comment.
I understood from the comments that the problem is that there are multiple spans in one message.

https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/19439/files#diff-36c4095ab777e510c637fccfa422a94bd7cb36631fb7a2071cf668da0d608b81R90-R117
I am trying to send a message to each span like this.

My branch is a draft and still being implemented!

@yurishkuro
Copy link
Member

Thanks for making OTEL PR, if that one is resolved it would make the Jaeger PR easy.

@yurishkuro
Copy link
Member

I added more comments to the original PR. I suggest closing this one - if you manage to land the OTEL change, you can take over #4049 to finish it off.

@metapox metapox closed this Mar 12, 2023
@metapox metapox deleted the support-otlp-kafka branch March 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants