Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.9 #410

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Upgrade to Go 1.9 #410

merged 2 commits into from
Oct 18, 2017

Conversation

yurishkuro
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 117d452 on go-1.8 into 489d7ed on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling efacab9 on go-1.8 into 489d7ed on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 170ee04 on go-1.8 into 489d7ed on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4453bac on go-1.8 into 489d7ed on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d0646ce on go-1.8 into 489d7ed on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d0646ce on go-1.8 into 489d7ed on master.

@yurishkuro yurishkuro changed the title Enable Go 1.8 Upgrade to Go 1.9 Oct 17, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 99.953% when pulling 4a4dec9 on go-1.8 into 0302c8d on master.

@vprithvi
Copy link
Contributor

gotestcover is deprecated and recommends using the following

echo 'mode: atomic' > coverage.txt && go list ./... | xargs -n1 -I{} sh -c 'go test -covermode=atomic -coverprofile=coverage.tmp {} && tail -n +2 coverage.tmp >> coverage.txt' && rm coverage.tmp

See: https://github.com/pierrre/gotestcover#deprecated

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7743ad5 on go-1.8 into 0302c8d on master.

@vprithvi
Copy link
Contributor

The branch name should be updated to go-1.9

@yurishkuro yurishkuro merged commit 897831a into master Oct 18, 2017
@ghost ghost removed the review label Oct 18, 2017
@yurishkuro yurishkuro deleted the go-1.8 branch October 18, 2017 14:14
ideepika pushed a commit to ideepika/jaeger that referenced this pull request Oct 22, 2017
* Upgrade to Go 1.9

Signed-off-by: Yuri Shkuro <[email protected]>
ideepika pushed a commit to ideepika/jaeger that referenced this pull request Oct 22, 2017
* Upgrade to Go 1.9

Signed-off-by: Yuri Shkuro <[email protected]>
isaachier pushed a commit to isaachier/jaeger that referenced this pull request Nov 1, 2017
* Upgrade to Go 1.9

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants