Restore NewGRPCHandler method #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prithvi Raj <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
==========================================
+ Coverage 97.07% 97.08% +0.01%
==========================================
Files 300 300
Lines 17701 17715 +14
==========================================
+ Hits 17183 17199 +16
+ Misses 416 415 -1
+ Partials 102 101 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 2, 2022
| if options.Tracer == nil { | ||
| options.Tracer = opentracing.NoopTracer{} | ||
| } | ||
|
|
There was a problem hiding this comment.
please add a test that passes empty options struct and validates that all 3 fields are not-nil in the result
yurishkuro
reviewed
Dec 2, 2022
| logger: logger, | ||
| tracer: tracer, | ||
| nowFn: func() time.Time { | ||
| grpcHandler := NewGRPCHandler(q, mq, GRPCHandlerOptions{ |
There was a problem hiding this comment.
+1 to actually use the func to prevent it from being deleted
Signed-off-by: Prithvi Raj <[email protected]>
yurishkuro
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prithvi Raj [email protected]
Which problem is this PR solving?
cmd/query/app.NewGRPCHandlerremoved without alternatives #4082Short description of the changes