-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS configuration for Admin Server #3679
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3679 +/- ##
==========================================
- Coverage 96.59% 96.57% -0.02%
==========================================
Files 268 268
Lines 15717 15742 +25
==========================================
+ Hits 15182 15203 +21
- Misses 445 449 +4
Partials 90 90
Continue to review full report at Codecov.
|
@@ -138,5 +169,6 @@ func (s *AdminServer) registerPprofHandlers() { | |||
|
|||
// Close stops the HTTP server | |||
func (s *AdminServer) Close() error { | |||
_ = s.tlsCertWatcherCloser.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can use multierr here to combine the two errors and return as one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In collectors, we can read that
watchers actually never return errors from Close
so, I'm not sure what multierr will bring in here ?
Signed-off-by: Matthieu MOREL <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Albert Teoh <[email protected]>
Short description of the changes
Signed-off-by: Matthieu MOREL [email protected]