Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-memory storage support for adaptive sampling #3335

Merged
merged 10 commits into from
Oct 25, 2021
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Srikanth Chekuri <[email protected]>
  • Loading branch information
srikanthccv and yurishkuro committed Oct 22, 2021
commit 9dc6d6d990ff6114654682a8885b7abdab5949b2
5 changes: 2 additions & 3 deletions plugin/storage/memory/lock.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Copyright (c) 2019 The Jaeger Authors.
// Copyright (c) 2017 Uber Technologies, Inc.
// Copyright (c) 2021 The Jaeger Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -19,7 +18,7 @@ import "time"

type lock struct{}

// Acquire always returns true for memory storage
// Acquire always returns true for memory storage because it's a single-node
func (l *lock) Acquire(resource string, ttl time.Duration) (bool, error) {
return true, nil
}
Expand Down
3 changes: 1 addition & 2 deletions plugin/storage/memory/lock_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Copyright (c) 2019 The Jaeger Authors.
// Copyright (c) 2017 Uber Technologies, Inc.
// Copyright (c) 2021 The Jaeger Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
3 changes: 1 addition & 2 deletions plugin/storage/memory/sampling.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Copyright (c) 2019 The Jaeger Authors.
// Copyright (c) 2017 Uber Technologies, Inc.
// Copyright (c) 2021 The Jaeger Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
3 changes: 1 addition & 2 deletions plugin/storage/memory/sampling_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Copyright (c) 2019 The Jaeger Authors.
// Copyright (c) 2017 Uber Technologies, Inc.
// Copyright (c) 2021 The Jaeger Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down