Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/fsnotify/fsnotify from 1.5.0 to 1.5.1 #3234

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 25, 2021

Bumps github.com/fsnotify/fsnotify from 1.5.0 to 1.5.1.

Release notes

Sourced from github.com/fsnotify/fsnotify's releases.

Revert Add AddRaw to not follow symlinks

#394

Changelog

Sourced from github.com/fsnotify/fsnotify's changelog.

[1.5.1] - 2021-08-24

  • Revert Add AddRaw to not follow symlinks
Commits
  • 466b39d prepare 1.5.1, retract 1.5.0
  • b98ede5 Revert "Add AddRaw to not follow symlinks + Fix link folloing on Windows (#289)"
  • dfdb645 revise pull request template
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner August 25, 2021 04:33
@dependabot dependabot bot requested a review from vprithvi August 25, 2021 04:33
@jpkrohling
Copy link
Contributor

Failed with:

=== RUN   TestHotReloadUIConfigTempFile
    static_handler_test.go:279: 
        	Error Trace:	static_handler_test.go:279
        	Error:      	"" does not contain "About a new Jaeger"
        	Test:       	TestHotReloadUIConfigTempFile
        	Messages:   	[{Entry:{Level:info Time:2021-08-25 04:38:46.894977692 +0000 UTC m=+2.453857423 LoggerName: Message:watching Caller:undefined Stack:} Context:[{Key:file Type:15 Integer:0 String:/tmp/ui-config-hotreload-2503521455/2594751846.json Interface:<nil>}]} {Entry:{Level:info Time:2021-08-25 04:38:46.894996892 +0000 UTC m=+2.453876623 LoggerName: Message:watching Caller:undefined Stack:} Context:[{Key:dir Type:15 Integer:0 String:/tmp/ui-config-hotreload-2503521455 Interface:<nil>}]} {Entry:{Level:info Time:2021-08-25 04:38:46.895082992 +0000 UTC m=+2.453962823 LoggerName: Message:reloading UI config Caller:undefined Stack:} Context:[{Key:filename Type:15 Integer:0 String:/tmp/ui-config-hotreload-2503521455/2594751846.json Interface:<nil>}]} {Entry:{Level:error Time:2021-08-25 04:38:46.895174093 +0000 UTC m=+2.454053924 LoggerName: Message:error while reloading the UI config Caller:undefined Stack:} Context:[{Key:error Type:26 Integer:0 String: Interface:cannot parse UI config file /tmp/ui-config-hotreload-2503521455/2594751846.json: unexpected end of JSON input}]} {Entry:{Level:info Time:2021-08-25 04:38:46.895186693 +0000 UTC m=+2.454066424 LoggerName: Message:reloaded UI config Caller:undefined Stack:} Context:[{Key:filename Type:15 Integer:0 String:/tmp/ui-config-hotreload-2503521455/2594751846.json Interface:<nil>}]}]

This is exactly the location we use this library, so, this update might break something for us.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #3234 (ce9fa90) into master (a0d9b55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3234   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         242      242           
  Lines       14789    14789           
=======================================
  Hits        14196    14196           
- Misses        513      514    +1     
+ Partials       80       79    -1     
Impacted Files Coverage Δ
cmd/collector/app/server/zipkin.go 68.29% <0.00%> (-2.44%) ⬇️
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d9b55...ce9fa90. Read the comment docs.

@jpkrohling
Copy link
Contributor

Interesting, this passed on the second try. Let's keep an eye on this test, perhaps it's a new intermittent one caused by this bump.

Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/fsnotify/fsnotify/releases)
- [Changelog](https://github.com/fsnotify/fsnotify/blob/master/CHANGELOG.md)
- [Commits](fsnotify/fsnotify@v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: github.com/fsnotify/fsnotify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/fsnotify/fsnotify-1.5.1 branch from ae41d76 to ce9fa90 Compare August 25, 2021 08:31
@albertteoh
Copy link
Contributor

@jpkrohling yeah, looks like the same flaky test popping up its head again: #3035.

I'll find some time to see if I can reproduce the issue.

@jpkrohling
Copy link
Contributor

Alright, it's not something new caused by this PR then. I'll go ahead and merge this one then. Thanks @albertteoh!

@jpkrohling jpkrohling enabled auto-merge (squash) August 25, 2021 09:06
@jpkrohling jpkrohling merged commit 7b0958d into master Aug 25, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/fsnotify/fsnotify-1.5.1 branch August 25, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants