Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment. #2984

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix comment. #2984

merged 1 commit into from
May 10, 2021

Conversation

sniperking1234
Copy link
Contributor

Signed-off-by: Chen Zhengwei [email protected]

Short description of the changes

  • Fix some comments.

Signed-off-by: Chen Zhengwei <[email protected]>
@sniperking1234 sniperking1234 requested a review from a team as a code owner May 10, 2021 07:59
@sniperking1234 sniperking1234 requested a review from albertteoh May 10, 2021 07:59
@mergify mergify bot requested a review from jpkrohling May 10, 2021 07:59
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #2984 (852c466) into master (6a11d73) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
- Coverage   95.97%   95.95%   -0.03%     
==========================================
  Files         223      223              
  Lines        9720     9720              
==========================================
- Hits         9329     9327       -2     
- Misses        324      325       +1     
- Partials       67       68       +1     
Impacted Files Coverage Δ
cmd/collector/app/options.go 100.00% <ø> (ø)
cmd/query/app/static_handler.go 95.16% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a11d73...852c466. Read the comment docs.

@jpkrohling jpkrohling merged commit b9e7dfb into jaegertracing:master May 10, 2021
@jpkrohling
Copy link
Contributor

Thanks!

albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request May 10, 2021
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants