Remove md-to-godoc #2598
Remove md-to-godoc #2598
Conversation
We have not used it actively. Addresses report https://groups.google.com/d/msgid/jaeger-tracing/020db716-6bbc-4aed-a61c-35715f0a5c1fn%40googlegroups.com Signed-off-by: Yuri Shkuro <[email protected]>
mergify
bot
dismissed
jpkrohling’s stale review
Pull request has been modified.
yurishkuro
force-pushed
the
remove-md-to-godoc
branch
from
dbaaff3 to
7cc3f10
Compare
|
Did you force-push to trigger the CI? |
|
I made a PR from stale master, so force push was after rebase. |
Signed-off-by: Yuri Shkuro <[email protected]>
mergify
bot
dismissed
jpkrohling’s stale review
Pull request has been modified.
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
| @@ -156,13 +156,14 @@ func TestStartStopRace(t *testing.T) { | |||
| { | |||
| Model: jaegerModel, | |||
| Protocol: compactProtocol, | |||
| Workers: 1, | |||
There was a problem hiding this comment.
don't need 10 goroutines in the test
| @@ -153,7 +147,7 @@ all-srcs: | |||
|
|
|||
| .PHONY: cover | |||
| cover: nocover | |||
| $(GOTEST) -coverprofile cover.out ./... | |||
| $(GOTEST) -timeout 5m -coverprofile cover.out ./... | |||
There was a problem hiding this comment.
default timeout is 10min, which is the same as Travis's no-output timeout, so Travis kills the job before go test has a chance to timeout and print the stack dump if there is a deadlock.
Codecov Report
@@ Coverage Diff @@
## master #2598 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 208 208
Lines 9281 9289 +8
=======================================
+ Hits 8847 8855 +8
Misses 355 355
Partials 79 79
Continue to review full report at Codecov.
|
We have not used it actively, and we don't make much use of godocs.