Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple storage dependencies and bump Go to 1.13.x #1886

Merged
merged 5 commits into from
Oct 29, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix quotes
Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
Yuri Shkuro committed Oct 29, 2019
commit 2a2f5e36cd53719f35eaed14d9b743dbafab586f
6 changes: 1 addition & 5 deletions cmd/flags/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,10 @@ package flags

import (
"flag"
"fmt"

"github.com/pkg/errors"
"github.com/spf13/viper"
"go.uber.org/zap"
"go.uber.org/zap/zapcore"

"github.com/jaegertracing/jaeger/plugin/storage"
)

const (
Expand Down Expand Up @@ -62,7 +58,7 @@ type logging struct {

// AddFlags adds flags for SharedFlags
func AddFlags(flagSet *flag.FlagSet) {
flagSet.String(spanStorageType, "", "(deprecated) please use SPAN_STORAGE_TYPE environment variable. Run this binary with "env" command for help.")
flagSet.String(spanStorageType, "", "(deprecated) please use SPAN_STORAGE_TYPE environment variable. Run this binary with the 'env' command for help.")
AddLoggingFlag(flagSet)
}

Expand Down