Use yarn for UI build #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Apr 12, 2017
.travis.yml
Outdated
| - sudo apt-key adv --keyserver pgp.mit.edu --recv D101F7899D41F3C3 | ||
| - echo "deb http://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list | ||
| - sudo apt-get update -qq | ||
| - sudo apt-get install -y -qq yarn |
There was a problem hiding this comment.
I would've thought sudo apt-get install -y -qq yarn should install all the dependencies.
There was a problem hiding this comment.
I'm basing this off travis-ci/travis-ci#6720 (comment)
black-adder
commented
Apr 12, 2017
travis/build-all-in-one-image.sh
Outdated
| @@ -10,7 +10,7 @@ echo "TRAVIS_BRANCH=$TRAVIS_BRANCH, REPO=$REPO, PR=$PR, BRANCH=$BRANCH, TAG=$TAG | |||
| make build-all-in-one-linux | |||
|
|
|||
| # Only push the docker container to Docker Hub for master branch | |||
| if [ "$BRANCH" == "master" ]; then echo 'upload to Docker Hub'; else echo 'skip docker upload for PR'; exit 0; fi | |||
| #if [ "$BRANCH" == "master" ]; then echo 'upload to Docker Hub'; else echo 'skip docker upload for PR'; exit 0; fi | |||
There was a problem hiding this comment.
this is just for testing, gonna upload the container to docker hub to make sure the UI works. Will uncomment later.
|
This works as intended; the containerized UI looks good. |
yurishkuro
approved these changes
Apr 12, 2017
.travis.yml
Outdated
| before_install: | ||
| # Repo for newer Node.js versions | ||
| - curl -sL https://deb.nodesource.com/setup_6.x | sudo -E bash - | ||
| # Repo for Yarn |
There was a problem hiding this comment.
please add a link https://yarnpkg.com/en/docs/install-ci#travis-tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install yarn in travis and use it for the UI build