Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always include reload-interval option for TLS config #6521

Closed
yurishkuro opened this issue Jan 11, 2025 · 0 comments · Fixed by #6525
Closed

Always include reload-interval option for TLS config #6521

yurishkuro opened this issue Jan 11, 2025 · 0 comments · Fixed by #6525
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jan 11, 2025 •
edited
Loading

See this discussion https://github.com/orgs/jaegertracing/discussions/6514#discussioncomment-11794401

Eliminate this option (treat it as always true)

jaeger/pkg/config/tlscfg/flags.go

Line 39 in 980dc31

EnableCertReloadInterval bool

@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Jan 11, 2025
@dosubot dosubot bot added the enhancement label Jan 11, 2025
@ADI-ROXX ADI-ROXX mentioned this issue Jan 11, 2025
Merged
4 tasks
yurishkuro added a commit that referenced this issue Jan 12, 2025
@ADI-ROXX @yurishkuro
Enable reload-interval flag for all TLS server configs (#6525)
c7e0b78 
## Which problem is this PR solving?
- Resolves #6521 

## Description of the changes
- Added the field EnableCertReloadInterval: true everywhere
ServerFlagsConfig is used
- As a dual check for future use, set the value of
c.EnableCertReloadInterval to true in AddFlags function in
pkg/config/tlscfg/flags.go

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
ekefan pushed a commit to ekefan/jaeger that referenced this issue Jan 14, 2025
@ADI-ROXX @yurishkuro @ekefan
Enable reload-interval flag for all TLS server configs (jaegertracing…
ed5a508 
…#6525)

## Which problem is this PR solving?
- Resolves jaegertracing#6521 

## Description of the changes
- Added the field EnableCertReloadInterval: true everywhere
ServerFlagsConfig is used
- As a dual check for future use, set the value of
c.EnableCertReloadInterval to true in AddFlags function in
pkg/config/tlscfg/flags.go

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable reload-interval flag for all TLS server configs ADI-ROXX/jaeger
1 participant
@yurishkuro