Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "docket images" CI/CD task to build for fewer architectures #4172

Closed
yurishkuro opened this issue Jan 21, 2023 · 5 comments · Fixed by #4286
Closed

Change "docket images" CI/CD task to build for fewer architectures #4172

yurishkuro opened this issue Jan 21, 2023 · 5 comments · Fixed by #4286

Comments

@yurishkuro
Copy link
Member

Requirement

As a developer I like CI/CD runs to take as little time as possible.

Problem

"Build docker images" workflow takes 30min now, because it builds binaries and images for all possible architectues.

Proposal

Consider reducing the number of architectures built for PRs, and only keep the full set for the main branch / release workflow.

Personally I would limit the PR builds to linux/amd86 architecture.

Open questions

No response

@yurishkuro yurishkuro changed the title [Maintenance]: Change "docket images" CI/CD task to build for fewer architectures Change "docket images" CI/CD task to build for fewer architectures Jan 21, 2023
@shubbham1215
Copy link
Contributor

Hi @yurishkuro, Could you give a brief about what changes would be a part of this ticket? I am looking to contribute to an issue for my academic requirement. I have already picked #4163 and will be working on it this week but the instructor has also mentioned picking something that would require a good amount of time to finish. Will this be a good issue? Or if there is some other issue you can assign me that as well.

@yurishkuro
Copy link
Member Author

@shubbham1215 the change would be mostly refactoring shell scripts / Makefile to pass fewer arch params to the docker build process. Around a week of work, including ramp-up.

good amount of time to finish

what amount of time do you want to allocate?

@shubbham1215
Copy link
Contributor

Okay. I think this issue is fine as it would require me much more than a week to finish it. Could you assign me this as well? Thanks.

@Eileen-Yu
Copy link
Contributor

Hi @yurishkuro Here is an initialized PR for this issue:
#4286

Since I'm pretty new here, would you help with review and let me know if anything you'd like to share?

@Eileen-Yu
Copy link
Contributor

/assign

yurishkuro added a commit that referenced this issue Mar 9, 2023
## Which problem is this PR solving?
- Resolves #4172

## Short description of the changes
- scripts/build-upload-docker-images.sh: Set platforms variable
dynamically based on ~~env `PLATFORMS`~~ the first argument
- .github/workflows/ci-docker-build.yml: Add a new job for PR only and
pass `pr-only` as the first argument

Signed-off-by: Eileen <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants