-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor Protobuf types generation (#5037)
## Which problem is this PR solving? - It was no longer possible to run `make proto` on Macs with Apple silicon since the Docker image with protobuf was only built for amd64. - We are generating unoptimized protobuf types for OTLP without Gogo, which will be a problem for jaeger-v2 ## Description of the changes - Upgrade jaegertracing/protobuf to https://github.com/jaegertracing/docker-protobuf/releases/tag/v0.5.0 - Move proto/thrift/crossdock-related targets into separate files `Makefile.*.mk` - Proto targets improvements - DRY targets by using a macro for invoking protoc - Separate different modules into different targets - Add some pretty logging ## How was this change tested? - `make proto` regenerates all the files without any additional changes ## Next steps - [ ] `proto-hotrod` produces a different file now, need to regenerate and test with HotROD, and then include it into the main `make proto` target - [ ] Thrift gen produces a different output (can't run it on Mac) - [ ] Utilize sed script from OTEL to add Gogo annotations to OTLP protos, to generate more efficient representation --------- Signed-off-by: Yuri Shkuro <[email protected]>
- Loading branch information
1 parent
16985d4
commit a798e25
Showing
6 changed files
with
267 additions
and
247 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.