Skip to content

Commit

Permalink
[idl check] Fetch tags (#6758)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- The test in #6753 was still failing, even with the submodule update

## Description of the changes
- Try to fetch tags

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Feb 19, 2025
1 parent ab25385 commit 46a7096
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci-lint-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ jobs:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
submodules: recursive
fetch-tags: true

- name: check jaeger-idl versions across git submodule and go.mod dependency
run: make lint-jaeger-idl-versions
Expand Down
1 change: 1 addition & 0 deletions scripts/lint/check-jaeger-idl-version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ get_gomod_version() {

get_submodule_version() {
cd idl
git fetch --tags
commit_version=$(git rev-parse HEAD)
semver=$(git describe --tags --exact-match "$commit_version")
if [ ! "$semver" ]; then
Expand Down

0 comments on commit 46a7096

Please sign in to comment.