Add error icon to errored services in trace list view #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 13, 2022 10:25
…actor existing constants to state. Signed-off-by: Jono Yan <[email protected]>
Signed-off-by: Jono Yan <[email protected]>
Signed-off-by: Jono Yan <[email protected]>
jaskerv
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
yurishkuro
reviewed
Apr 13, 2022
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.tsx
Show resolved
Hide resolved
yurishkuro
reviewed
Apr 13, 2022
| return hasError; | ||
| }).length; | ||
|
|
||
| this.state = { |
There was a problem hiding this comment.
just curious, how/where is this .state field associated with the State type?
There was a problem hiding this comment.
export default class ResultItem extends React.PureComponent<Props, State> {
It is associated here :)
Codecov Report
@@ Coverage Diff @@
## main #927 +/- ##
==========================================
+ Coverage 95.25% 95.43% +0.17%
==========================================
Files 240 240
Lines 7510 7518 +8
Branches 1883 1886 +3
==========================================
+ Hits 7154 7175 +21
+ Misses 350 337 -13
Partials 6 6
Continue to review full report at Codecov.
|
|
Could you please add or modify a unit test to add coverage the new conditional code? |
added 2 commits
April 13, 2022 13:29
Signed-off-by: Jono Yan <[email protected]>
Signed-off-by: Jono Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #925
Short description of the changes
ResultItem.tsx.