Monitor Tab - Request rate number more readable #890
Conversation
Signed-off-by: nofar9792 <[email protected]>
…o request-rate-two-decimal-places
…o request-rate-two-decimal-places
nofar9792
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Codecov Report
@@ Coverage Diff @@
## main #890 +/- ##
==========================================
+ Coverage 95.37% 95.43% +0.05%
==========================================
Files 240 240
Lines 7462 7466 +4
Branches 1865 1866 +1
==========================================
+ Hits 7117 7125 +8
+ Misses 339 335 -4
Partials 6 6
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| // Truncate number to two decimal places | ||
| return `${value.toString().match(/^-?\d+(?:\.\d{0,2})?/)![0]} req/s`; |
There was a problem hiding this comment.
Nit: this is not so much a question of decimal places, but of precision. E.g. 2.666667 is just as useless (too much precision) as 26666.67, but this code will allow the latter, whereas I would prefer to represent it as 26.6k - never more than 3 digits of precision
There was a problem hiding this comment.
Good point and totally accepted. However, will be better just to go this path right now, and just improve on another iteration. Your comment definitely enhances the solution, but the current step will already provide an improvement which is immediate.
Which problem is this PR solving?
Resolves #889
Short description of the changes
before:
after:
before:
after:
