Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceSpanTable View #772

Closed
wants to merge 132 commits into from
Closed

TraceSpanTable View #772

wants to merge 132 commits into from

Conversation

vvvprabhakar
Copy link
Contributor

Why trace span table? Issue(#690)
A trace with many spans trace (~20K) spans can be broken down into pieces and analyzed. Have a link with traceTimeline View as well to link both views and get the analysis of trace
Gives a detailed view of a service or an operation and its impact on a trace,

What can we achieve?

  • Filter Spans with multiple serviceName values

  • Filter Spans with multiple OperationName values

  • Filter with both ServiceName and OperationName

  • Sort based on duration and startTime

  • Each row in the table has spanID link which will take the user to that particular span in traceTimelineView

  • Either search with text on serviceName and OperatioName Columns

  • Pagination for the spans

What can we improve from here?

  • We can add SelfTime in the table as a column and make it sortable

Dependieces Used

  • Used antd for table

  • Used react-highlighter for the search word highlighting

**Screenshot 2021-06-23 at 15 51 11
Screenshot 2021-06-23 at 15 51 20
Screenshot 2021-06-23 at 15 51 36
Screenshot 2021-06-23 at 15 52 11
**

@vvvprabhakar vvvprabhakar changed the title TraceSpanTable View WIP:TraceSpanTable View Jun 23, 2021
@vvvprabhakar vvvprabhakar changed the title WIP:TraceSpanTable View TraceSpanTable View Jul 4, 2021
objectiser and others added 22 commits July 5, 2021 03:16
@objectiser @vvvprabhakar
Update lodash from 4.17.15 to 4.17.19 (jaegertracing#598)
687932f 
Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@objectiser @vvvprabhakar
Fixed missing 'types/node' dependency (jaegertracing#603)
fc67640 
Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@vankop @vvvprabhakar
span bar row size fix. resolves jaegertracing#589 (jaegertracing#599)
7f7a4a9 
(cherry picked from commit 3fe952ab8c829072c4e6cd314bfd656c1d1ebfe5)
Signed-off-by: Ivan Kopeykin <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@everett980 @vvvprabhakar
Tweak css definition for span tree offset color (jaegertracing#604)
af57710 
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@yurishkuro @vvvprabhakar
Render seconds in dark color, millis in light (jaegertracing#605)
802bb1a 
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@fylip97 @everett980 @vvvprabhakar
Added view for showing detailed trace statistics (jaegertracing#506)
0243db2 
* Added view for showing detailed trace statistics
* Reworked trace statistics ui
* review included
* feedback added
Signed-off-by: Philip Dengler <[email protected]>

* Handle merge conflict, clean up AltViewOptions style
Signed-off-by: Everett Ross <[email protected]>

Co-authored-by: Philip <[email protected]>
Co-authored-by: Everett Ross <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Update legacy React lifecycle methods to indicate unsafe status (jaeg…
669937a 
…ertracing#610)

Following the react migration path laid out here https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @yurishkuro @vvvprabhakar
Add unit coverage for component TraceIDSearchInput (jaegertracing#616)
2e8e308 
* add unit coverage for component TraceIDSearchInput

Signed-off-by: Tim Klever <[email protected]>

* Correct copyright holder

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Tim Klever <[email protected]>

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Clear console errors (proptype violations) from CLI output (jaegertra…
b4a3c45 
…cing#615)

These tests, due to missing required props, were leaving console.error messages in the test run CLI output. It doesn't effect the tests, it doesn't cause any false positives or negatives, but it could be seen as a distraction seeing red output fly across the screen in an otherwise passing test.

Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Refactor UNSAFE_componentWillReceiveProps to use componentDidUpdate (j…
56c9ab2 
…aegertracing#612)

Migrating these componentWillRecieveProps calls to componentDidUpdate in line with recommendations provided at https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops, stating "If you need to perform a side effect (for example, data fetching or an animation) in response to a change in props, use componentDidUpdate"

Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Migrate ArchiveNotifier from UNSAFE_componentWillReceiveProps (jaeger…
50c7b63 
…tracing#614)

Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Remove UNSAFE_componentWillMount lifecycle methods (jaegertracing#611)
3cd49c6 
Refactor components to no longer use UNSAFE_componentWillMount methods adhering to current React best practices.

Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Refactor SpanGraph.UNSAFE_componentWillReceiveProps (jaegertracing#613)
5916119 
* add test to ensure canvas graph rendering is limited

This test codifies the sentiments on SpanGraph/index.tsx#L35, confirming that canvas graph is not re-rendered unless trace is changed

Signed-off-by: Tim Klever <[email protected]>

* refactor SpanGraph to not use internal state for memoization

Using component state in this manner is considered a react anti-pattern. By removing it, not only is the size and complexity of the component reduced, but it enables the removal of the legacy method UNSAFE_componentWillReceiveProps

Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Add ArchiveNotifier tests (jaegertracing#619)
d13037c 
* adding test coverage around current ArchiveNotifier component functionality

Signed-off-by: Tim Klever <[email protected]>

* clean up some outdated comments and remove some erroneous logic

Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
Add rubenvp8510 to code owners
172658b 
Per vote here jaegertracing#621

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @rubenvp8510 @vvvprabhakar
Additional Test Coverage around TimelineViewingLayer (jaegertracing#617)
1ca8c4b 
* add additional tests around existing TimelineViewingLayer functionality

In addition to rounding out the test suite, this commit also removes some of the "Math.random" calls from the test suite. These randoms were causing some code coverage jitter in the test suite by randomly executing certain code paths. Removing these randomizations will keep coverage reporting consistent and avoid random "coverage losses" based on chance.

Signed-off-by: Tim Klever <[email protected]>

* migrate from callback ref to CreateRef in TimelineViewingLayer

CreateRef API was introduced in React 16.3

Signed-off-by: Tim Klever <[email protected]>

Co-authored-by: Ruben Vargas Palma <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@objectiser @vvvprabhakar
Preparing release v1.10.0 (jaegertracing#627)
38ed53c 
Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@rubenvp8510 @vvvprabhakar
Fix TraceTimelineViewer span details render issue (jaegertracing#629)
41ae1ce 
* Fixes TraceTimelineViewer span details

Signed-off-by: Ruben Vargas <[email protected]>

* perform deep comparision for memoized ViewBoundsFunc and GetCssClasses

Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@dependabot @vvvprabhakar
Bump http-proxy from 1.17.0 to 1.18.1 (jaegertracing#632)
2cb86fc 
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](http-party/node-http-proxy@1.17.0...1.18.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: vvvprabhakar <[email protected]>
@rubenvp8510 @vvvprabhakar
Improve styling of trace statistics selectors (jaegertracing#639)
c053f6a 
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@tklever @vvvprabhakar
Add coverage around existing TraceName component (jaegertracing#626)
a204745 
Signed-off-by: Tim Klever <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@rubenvp8510 @vvvprabhakar
Preparing release v1.11.0 (jaegertracing#644)
ee0d707 
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
meenal06 and others added 27 commits July 5, 2021 03:16
@meenal06 @vvvprabhakar
Upgrade to react-router-dom v5.2.0 (jaegertracing#727)
65937c1 
* feat: upgrade to react-router-dom v5.2.0

Signed-off-by: Meenal Trivedi <[email protected]>

* fix: lint

Signed-off-by: Meenal Trivedi <[email protected]>

* fix

Signed-off-by: Meenal Trivedi <[email protected]>

* update snapshots to accomodate latest changes

Signed-off-by: Meenal Trivedi <[email protected]>

* fix

Signed-off-by: Meenal Trivedi <[email protected]>

* fix: object only has getter

Signed-off-by: Meenal Trivedi <[email protected]>

* fix: tests

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
signoff
d3e483f 
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
signoff
7aae13e 
Signed-off-by: vvvprabhakar <[email protected]>
@dependabot @vvvprabhakar
Bump memoize-one from 5.0.0 to 5.1.1 (jaegertracing#739)
4bc9de5 
Bumps [memoize-one](https://github.com/alexreardon/memoize-one) from 5.0.0 to 5.1.1.
- [Release notes](https://github.com/alexreardon/memoize-one/releases)
- [Commits](alexreardon/memoize-one@v5.0.0...v5.1.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: vvvprabhakar <[email protected]>
@yurishkuro @vvvprabhakar
Add Slack sign-up link
596cd1d 
Signed-off-by: vvvprabhakar <[email protected]>
@yurishkuro @vvvprabhakar
Delete issue templates in favor of global ones
0f1c2bc 
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@jpkrohling @vvvprabhakar
Bump handlebars to 4.7.7 (jaegertracing#763)
82a0ccc 
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@jpkrohling @vvvprabhakar
Prepare release v1.14.0 (jaegertracing#764)
dac6507 
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@jpkrohling @vvvprabhakar
Fix jaeger-ui package version (jaegertracing#765)
50064f8 
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
span table dependency changes
45f4d14 
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
signoff
71a8064 
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
Revert "Bump merge-deep from 3.0.2 to 3.0.3 (jaegertracing#766)"
60b4ca5 
This reverts commit 1e43500.

Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
Error commits in branch removing
acd5c4f 
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
signoff
55bfb2a 
Signed-off-by: vvvprabhakar <[email protected]>
@kevinearls @vvvprabhakar
Update jest to produce a junit report for tests (jaegertracing#723)
9b79c8f 
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <[email protected]>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@meenal06 @vvvprabhakar
[chore]: gitignore the generated unit test report (jaegertracing#726)
5243548 
Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
c76e541 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
signoff
9d237c4 
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar
signoff
e97bf81 
Signed-off-by: vvvprabhakar <[email protected]>
@meenal06 @vvvprabhakar
Upgrade to react-router-dom v5.2.0 (jaegertracing#727)
3669eb9 
* feat: upgrade to react-router-dom v5.2.0

Signed-off-by: Meenal Trivedi <[email protected]>

* fix: lint

Signed-off-by: Meenal Trivedi <[email protected]>

* fix

Signed-off-by: Meenal Trivedi <[email protected]>

* update snapshots to accomodate latest changes

Signed-off-by: Meenal Trivedi <[email protected]>

* fix

Signed-off-by: Meenal Trivedi <[email protected]>

* fix: object only has getter

Signed-off-by: Meenal Trivedi <[email protected]>

* fix: tests

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@dependabot @vvvprabhakar
Bump cytoscape-dagre from 2.2.2 to 2.3.2 (jaegertracing#735)
29deec5 
Bumps [cytoscape-dagre](https://github.com/cytoscape/cytoscape.js-dagre) from 2.2.2 to 2.3.2.
- [Release notes](https://github.com/cytoscape/cytoscape.js-dagre/releases)
- [Commits](cytoscape/cytoscape.js-dagre@v2.2.2...v2.3.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: vvvprabhakar <[email protected]>
@dependabot @vvvprabhakar
Bump @babel/cli from 7.2.3 to 7.13.14 (jaegertracing#738)
c7f0d45 
Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.2.3 to 7.13.14.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.14/packages/babel-cli)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: vvvprabhakar <[email protected]>
@dependabot @vvvprabhakar
Bump memoize-one from 5.0.0 to 5.1.1 (jaegertracing#739)
2c74d0f 
Bumps [memoize-one](https://github.com/alexreardon/memoize-one) from 5.0.0 to 5.1.1.
- [Release notes](https://github.com/alexreardon/memoize-one/releases)
- [Commits](alexreardon/memoize-one@v5.0.0...v5.1.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: vvvprabhakar <[email protected]>
@yurishkuro @vvvprabhakar
Add Slack sign-up link
16e4f86 
Signed-off-by: vvvprabhakar <[email protected]>
@yurishkuro @vvvprabhakar
Delete issue templates in favor of global ones
2569511 
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@jpkrohling @vvvprabhakar
Bump handlebars to 4.7.7 (jaegertracing#763)
ce8d919 
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@jpkrohling @vvvprabhakar
Fix jaeger-ui package version (jaegertracing#765)
a772275 
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar vvvprabhakar deleted the span-table branch July 5, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everett980 everett980 Awaiting requested review from everett980

@rubenvp8510 rubenvp8510 Awaiting requested review from rubenvp8510

@tiffon tiffon Awaiting requested review from tiffon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.