Add adblocker and 0/single node disclaimers #502
Conversation
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 92.87% 92.89% +0.01%
==========================================
Files 197 197
Lines 4789 4797 +8
Branches 1155 1159 +4
==========================================
+ Hits 4448 4456 +8
Misses 300 300
Partials 41 41
Continue to review full report at Codecov.
|
|
there seems to be many changes not related to just disclaimers |
|
@yurishkuro the PR is branched off of another PR. There is a link in the PR description to the commit that contains the disclaimer changes. |
|
The middle branch was merged, so the diff is good now (except for two files with TODO delete changes comments that I definitely deleted on the middle branch.....) |
| @@ -20,6 +20,10 @@ export default deepFreeze( | |||
| Object.defineProperty( | |||
| { | |||
| archiveEnabled: false, | |||
| // TODO: remove default | |||
| deepDependencies: { | |||
| menuEnabled: true, | |||
There was a problem hiding this comment.
Do we really want that in oss? There's no backend to generate DDGs.
There was a problem hiding this comment.
yeah hence the TODO and comment above that I thought TODOs were dealt with...
definitely won't have this on by default. same with the New! css
Signed-off-by: Everett Ross <[email protected]>
* Temp: Default link visible with banner Signed-off-by: Everett Ross <[email protected]> * WIP: Use server ops in ddg, track conv&collapse Signed-off-by: Everett Ross <[email protected]> * Add tests Signed-off-by: Everett Ross <[email protected]> * Add disclaimers for (near) empty graph&adblocker Signed-off-by: Everett Ross <[email protected]> * Remove default enabled Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Which problem is this PR solving?
Short description of the changes
("New!" banner not in diff)
No dependencies found:
Dependencies found but hidden:
This PR is branched off of another PR, this commit contains the diff for this PR